Feature/y websocket jwt auth - #797
Open
NishikawaKoharu wants to merge 5 commits into
Open
NishikawaKoharu wants to merge 5 commits into
NishikawaKoharu wants to merge 5 commits into
Conversation
yacchin1205
requested changes
Sep 17, 2026
yacchin1205
left a comment
There was a problem hiding this comment.
いくつか変更した方が良い点を見つけております。GitHubではなくチケットに記載したいので許可をいただけますと幸いです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Issue signed JWTs for y-websocket connections used by Wiki collaborative editing, so only users with write permission can authenticate to the WebSocket endpoint.
This is a security hardening change to prevent unauthenticated y-websocket access.
Changes
Y_WEBSOCKET_SECRET,Y_WEBSOCKET_JWT_ALGORITHM, andY_WEBSOCKET_TOKEN_TTLsettingsgenerate_y_websocket_token()to issue JWTs for editable wiki pagesyWebsocketTokento the edit page viaedit.mako/contextVarsQA Notes
Y_WEBSOCKET_SECRETis unset, the token remains an empty string (backward compatible)yWebsocketTokenis present in page contextY_WEBSOCKET_SECRETconfigured, verify collaborative editing still works together with the wiki-frontend client change and the authenticated y-websocket imageDocumentation
Y_WEBSOCKET_SECRET(and optionallyY_WEBSOCKET_TOKEN_TTL)Side Effects
RDM-wiki-frontendand the y-websocket auth imageRelated PRs
Bitbucket
GitHub
Ticket
https://redmine.devops.rcos.nii.ac.jp/issues/60810