feat(hyprland): migrate configuration to lua - #59
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0f7df09a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "autostart" = '' | ||
| hl.exec_once("[ workspace special:scratchy silent ] alacritty -t scratchy") | ||
| hl.exec_once("[ workspace special:aux silent ] sleep 2 && chromium --profile-directory=Default --app-id=dlgohinmglaoopaiplliaecdpmnepmga") | ||
| ${lib.concatMapStringsSep "\n" (cmd: "hl.exec_once(\"${cmd}\")") cfg.autostart} |
There was a problem hiding this comment.
When a roles.desktop.hyprland.autostart entry contains quotes, backslashes, or a newline—for example, a command with a quoted shell argument—this interpolation inserts those characters directly into the Lua string, potentially changing the command or making the generated configuration invalid. The option accepts arbitrary strings and the previous Home Manager settings serializer escaped them, so serialize each command as a valid Lua-compatible quoted string instead of wrapping ${cmd} manually.
Useful? React with 👍 / 👎.
a0f7df0 to
5e2054b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e2054b0ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| hl.bind("MOD5", "C", "exec, noctalia msg panel-toggle control-center calendar") | ||
| hl.bind("MOD5", "S", "exec, noctalia msg panel-toggle control-center monitor") | ||
| hl.bind("MOD5", "V", "exec, noctalia msg panel-toggle clipboard") |
There was a problem hiding this comment.
When the configured EurKEY or German layouts are active, MOD5 is AltGr, so these global bindings intercept character-entry combinations—most notably AltGr+S, which should type ß, but now opens the system monitor instead. This directly reintroduces the keyboard conflict documented in NOCTALIA_MODE_PLAN.md:3-8 and affects the layouts configured in default.nix:83-85; move these actions behind a non-AltGr shortcut or submap.
Useful? React with 👍 / 👎.
1 participant
Summary
configType = "lua"andextraLuaFilessettings,rules,autostart, andkeybinds)Stacked on top of #56 (
feat/noctalia-shell).