fix(postgres): inOpenTransaction must detect BEGIN without an assigned XID - #860
Merged
Merged
Conversation
Track BEGIN/COMMIT/ROLLBACK on the session so SELECT-only transactions keep the SQL-tab badge on. Fall back to xact_start (PG 9+) instead of pg_current_xact_id_if_assigned.
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEGIN+SELECTdoes not assign an XID, sopg_current_xact_id_if_assignedstayed NULL (badge off; autocommit-off prepended a secondBEGIN).ROLLBACK TOstays open). Otherwise probespg_stat_activity.xact_startforpg_backend_pid()(PG 9+; no PG 13 requirement).execute(Parse cannot takeBEGIN;concatenated with the next statement).Test plan
BEGINthenSELECT 1— transaction badge is on.COMMIT/ROLLBACK— badge off.SELECTissues a separateBEGIN, notBEGIN; SELECT …in one Parse.Closes #787