fix(postgres): browse on read-only; page with ORDER BY PK; do not block on COUNT(*) - #859
Merged
Merged
Conversation
Browse stays read-only. Row totals use reltuples so a sequential COUNT cannot forceClose the pooled socket. Stale estimates below the page leave Next enabled.
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PgSessionMode.readOnly. Save / REFRESH stay ontableWrite.SELECTusesORDER BYprimary-key columns when a PK exists (schema is loaded before the page query).pg_class.reltuplesinstead of blockingCOUNT(*). Stale estimates below the current page are ignored so Next still works.Test plan
ORDER BYthose columns; paging is stable.COUNT(*); Next works when the page is full even ifreltuplesis stale/low.ORDER BY. Save / REFRESH still usetableWrite.Closes #788