-
Notifications
You must be signed in to change notification settings - Fork 0
fix(extensions): Table Browser must require PK and not discard dirty edits #869
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingdata-gridInteractive data grid, cell editor, filtering, groupingsInteractive data grid, cell editor, filtering, groupingserror-handlingTheme parser epic label: error-handlingTheme parser epic label: error-handlingmarketplaceExtensions marketplace, ExtensionManifestExtensions marketplace, ExtensionManifestuxUser experience, keyboard shortcuts and interactionsUser experience, keyboard shortcuts and interactions
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdata-gridInteractive data grid, cell editor, filtering, groupingsInteractive data grid, cell editor, filtering, groupingserror-handlingTheme parser epic label: error-handlingTheme parser epic label: error-handlingmarketplaceExtensions marketplace, ExtensionManifestExtensions marketplace, ExtensionManifestuxUser experience, keyboard shortcuts and interactionsUser experience, keyboard shortcuts and interactions
Summary
Extension Table Browser is fail-open vs native Table Browser after #771 / #772 / #773.
supportsMutationsis true — no PK / schema loaded check.ExtensionDriverSession.getTableSchemacatches errors and returns an emptyTableSchemaMeta. Save then builds UPDATE/DELETEWHEREfrom every column.dispose()the staging buffer with no confirm. NoUnsavedWorkRegistry.affectedRows ?? mutations.length— a driver that omits or zeroesaffectedRowsstill looks like a full success. NoexpectDmlMatchedRows.Repro
db.getTableSchema→ cells still editable; Save can update multiple rows.Scope
affectedRowsis 0 / missing, matching native DML.Out of scope