Skip to content

fix(grid): schema load failure must not look like missing PK #772

Description

@ZhuchkaTriplesix

Summary

Table Browser _ensureSchema swallows getTableSchema errors and sets primaryKeys = [] + schemaLoaded = true. The status line then says Cannot edit: no primary key detected even when the PK query failed (permissions, disconnect).

Scope

  • Distinguish “no PK” vs “schema unavailable”.
  • Keep editing disabled; show the real error (or a Retry).
  • Cover in table_view_staging / table-view tests with a throwing schema stub.

Out of scope

  • SQLite implicit rowid as a PK fallback (separate issue).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdata-gridInteractive data grid, cell editor, filtering, groupingserror-handlingTheme parser epic label: error-handling

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions