feat(router): complete requiresSearch policy integrity - #55
Closed
cryptoxdog wants to merge 1 commit into
Closed
Conversation
Close the remaining gaps of the requiresSearch-authoritative policy (#45): - Fail closed on search+vision: a search-required route carrying images now throws UnsupportedCapabilityCombinationError (code SEARCH_VISION_COMBINATION_UNSUPPORTED) at resolution time, before budget reservation and provider dispatch. Previously resolveRoute selected the text-only Perplexity path and silently dropped the images. - Remove the unreachable disableSearch logic in resolvePerplexityConfig: a Perplexity route is only selected when search is required, so the resolved config now always enables search (field kept for 1.x provider config compatibility). - Add routing audit evidence to every RoutingResolution/RoutingDecision: searchRequired (boolean) and searchPolicySource (EXPLICIT | TASK_DEFAULT), exposed through route() and the call log. - Classify the new capability-combination error as a local error so it can never poison provider circuit health. - Add tests/routing-matrix.test.ts: table-driven matrix A-M, audit evidence, dispatch-path selection with injected provider doubles, consensus non-authority, and Perplexity config/route agreement. verify:all passes (build, types, declarations, lint, provider-boundary, 125 tests, audit, package smoke). Co-Authored-By: Claude <noreply@anthropic.com>
|
Collaborator
Author
|
Superseded by campaign/7-router-capability-integrity (capability-integrity hardening, blueprint llm_router_capability_integrity_3045134d). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Governance Checklist
setup_workspace_symlinks.sh, symlinks resolve (§2)ls -la .cursor/rules .cursor/skills .cursor/commandsall resolve@v1, never@mainor bare SHABreaking Change
If checked, describe the impact and migration path:
Rollback Plan
Related Issues
Closes #
Commits
Test plan
make pr-check(local changed-files gate) PASS before open