fix(console): classify token exchange failures safely - #482
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A fresh login after the timeout patch reached token exchange but failed without an attributable error. Expose only the HTTP status and four documented GitHub error categories on the existing 502 page and fixed diagnostic log. Unknown values become unknown; never expose provider descriptions, URLs, authorization codes, state, tokens, or credentials.
The request, authorization checks, success condition, cookie clearing, timeout, and no-retry behavior remain unchanged.
Validation
Node syntax and git diff --check passed. Independent static privacy/authentication review passed. No local tests added or run. Existing CI and a bounded fresh login after deployment are separate acceptance checks; the upstream failure category is still unknown.