Repository navigation
fix: explain and test the as_of UTC time contract - #90
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit
as_ofrequest made before the next UTC midnight is correctly rejected, but the error omits the date and earliest valid generation time. Include those values and the normalized actual time so callers can correct the request without weakening the closed-day contract.Document UTC input semantics and empty-input defaults. Add boundary cases for the last microsecond before cutoff, exact equality, and equivalent positive/negative offsets. The cutoff calculation, default dates, freshness checks, advisory decisions, workflow schedules and trading/execution logic are unchanged.
Validation: reproduced the original missing-cutoff diagnostic from the base commit; baseline focused tests: 29 passed; updated full offline suite: 413 passed;
git diff --checkpassed. No advisory review, market-data collection, notification or deployment was dispatched.