Repository navigation
fix: harden isolated preview bundle readback - #89
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview bundle readback currently accepts symbolic links and mutable nested evidence. Reject non-regular entries through descriptor-based reads, require canonical manifest bytes and a mapping source, and recursively freeze evidence. Atomic publication now refuses to replace a concurrent destination, including an empty directory.
Validation: six new regressions failed before the fix; 30 preview/workspace tests pass locally. The real no-replace primitive is exercised on macOS; CI also exercises Linux. Unsupported exclusive-publication platforms fail safely. Source v5 keeps the existing rule that an explicit contract_version field is forbidden.
Closes #50. This changes isolated preview files only.