Skip to content

fix: admit reviewed USD account history producers #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 2 commits into from
Sep 29, 2026
Merged

fix: admit reviewed USD account history producers #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f88717
fix: admit reviewed USD account history producers
Pigbibi Sep 29, 2026
0b2ec66
fix: align bounded workflow and fixtures with USD candidates
Pigbibi Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/sync-cloud-run-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ jobs:
# Trusted control code stays on this main checkout. The application archive is chosen below.
approved_candidate=0b939723c1db3ef59175535998b470cbcd4b8824
approved_http_snapshot_candidate=d8314a61df697cae1dd03a78ddc5c2fc4179ec67
approved_probe_snapshot_candidate=a2921d157efb887e9210fad6734ca040ea6e5293
approved_sghk_snapshot_candidate=922f338fea7c46391b50bb8316ac88154596916f
approved_probe_snapshot_candidate=318bf0419ec91002fd0f0dfd1bc80a0664a85e79
approved_sghk_snapshot_candidate=df3d29d13daeffc7b4af9fec5db0e9ec1f07b60f
history_count=0
for history_value in \
"${ACCOUNT_HISTORY_RECORDING_ENABLED:-}" \
Expand Down Expand Up @@ -330,8 +330,8 @@ jobs:
set -euo pipefail
approved_candidate=0b939723c1db3ef59175535998b470cbcd4b8824
approved_http_snapshot_candidate=d8314a61df697cae1dd03a78ddc5c2fc4179ec67
approved_probe_snapshot_candidate=a2921d157efb887e9210fad6734ca040ea6e5293
approved_sghk_snapshot_candidate=922f338fea7c46391b50bb8316ac88154596916f
approved_probe_snapshot_candidate=318bf0419ec91002fd0f0dfd1bc80a0664a85e79
approved_sghk_snapshot_candidate=df3d29d13daeffc7b4af9fec5db0e9ec1f07b60f
case "${WORKFLOW_TARGET}" in
HK) expected_sghk_target=hk ;;
SG) expected_sghk_target=sg ;;
Expand Down
4 changes: 2 additions & 2 deletions scripts/verify_deployed_runtime_target_admission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ class AdmissionError(ValueError):
# Reviewed PAPER HTTP snapshot image. Distinct from the natural-cycle history archive above.
APPROVED_PAPER_HTTP_SNAPSHOT_CANDIDATE = "d8314a61df697cae1dd03a78ddc5c2fc4179ec67"
# Reviewed PAPER internal-probe snapshot producer. It carries no history or snapshot env update.
APPROVED_PAPER_PROBE_SNAPSHOT_CANDIDATE = "a2921d157efb887e9210fad6734ca040ea6e5293"
APPROVED_PAPER_PROBE_SNAPSHOT_CANDIDATE = "318bf0419ec91002fd0f0dfd1bc80a0664a85e79"
# Reviewed read-only SG/HK account-snapshot producer. It is not a PAPER candidate.
APPROVED_SGHK_ACCOUNT_SNAPSHOT_CANDIDATE = "922f338fea7c46391b50bb8316ac88154596916f"
APPROVED_SGHK_ACCOUNT_SNAPSHOT_CANDIDATE = "df3d29d13daeffc7b4af9fec5db0e9ec1f07b60f"
# One already-staged PAPER revision that may hold history env while serving still runs an older image.
_PAPER_HTTP_STAGED_SOURCE_REVISION = "longbridge-quant-paper-service-r36423178119"
_PAPER_HTTP_STAGED_SOURCE_COMMIT = APPROVED_PAPER_HISTORY_CANDIDATE
Expand Down
12 changes: 6 additions & 6 deletions tests/test_sync_cloud_run_env_workflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,8 @@ assert 'git archive "${SOURCE_COMMIT}"' not in job
assert "git archive ${{" not in job
assert "0b939723c1db3ef59175535998b470cbcd4b8824" in job
assert "d8314a61df697cae1dd03a78ddc5c2fc4179ec67" in job
assert "a2921d157efb887e9210fad6734ca040ea6e5293" in job
assert "922f338fea7c46391b50bb8316ac88154596916f" in job
assert "318bf0419ec91002fd0f0dfd1bc80a0664a85e79" in job
assert "df3d29d13daeffc7b4af9fec5db0e9ec1f07b60f" in job
assert '[ "${GITHUB_REPOSITORY:-}" != "QuantStrategyLab/LongBridgePlatform" ]' in job
assert '[ "${SOURCE_COMMIT}" = "${GITHUB_SHA}" ] || [ "${SOURCE_COMMIT}" = "${approved_candidate}" ]' not in job
for forbidden in ("sync_plan", "scheduler", "cleanup", "retire", "update-traffic"):
Expand Down Expand Up @@ -476,8 +476,8 @@ with open(os.environ["STUB_LOG"], "a") as stream:
stream.write(json.dumps([command, *args]) + "\\n")
approved = "0b939723c1db3ef59175535998b470cbcd4b8824"
http_snapshot_candidate = "d8314a61df697cae1dd03a78ddc5c2fc4179ec67"
probe_snapshot_candidate = "a2921d157efb887e9210fad6734ca040ea6e5293"
sghk_snapshot_candidate = "922f338fea7c46391b50bb8316ac88154596916f"
probe_snapshot_candidate = "318bf0419ec91002fd0f0dfd1bc80a0664a85e79"
sghk_snapshot_candidate = "df3d29d13daeffc7b4af9fec5db0e9ec1f07b60f"
staged_source_revision = "longbridge-quant-paper-service-r36423178119"
staged_source_image = (
"asia-east1-docker.pkg.dev/synthetic-project/images/longbridgeplatform/synthetic-paper"
Expand Down Expand Up @@ -712,8 +712,8 @@ else:
}
candidate = "0b939723c1db3ef59175535998b470cbcd4b8824"
http_snapshot_candidate = "d8314a61df697cae1dd03a78ddc5c2fc4179ec67"
probe_snapshot_candidate = "a2921d157efb887e9210fad6734ca040ea6e5293"
sghk_snapshot_candidate = "922f338fea7c46391b50bb8316ac88154596916f"
probe_snapshot_candidate = "318bf0419ec91002fd0f0dfd1bc80a0664a85e79"
sghk_snapshot_candidate = "df3d29d13daeffc7b4af9fec5db0e9ec1f07b60f"
staged_source_revision = "longbridge-quant-paper-service-r36423178119"
staged_source_image = (
"asia-east1-docker.pkg.dev/synthetic-project/images/longbridgeplatform/"
Expand Down
Loading