fix: distinguish SG execution blocks and holding currencies - #527
Merged
Merged
Conversation
…currencies Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SG heartbeats currently collapse a durable execution block into “no executable orders” and show holding values with an ambiguous dollar sign. Render explicit blocked and queued-window outcomes from execution fields, and carry same-cycle broker position currencies into holding labels with an unverified fallback.
Preserve direct-routing protection, durable command state transitions, account identity checks and broker order behavior. A queued future command still blocks direct routing while its heartbeat correctly says it is waiting.
Validation: 123 tests and 31 subtests passed in the locked dependency environment; Ruff and diff checks passed. Independent Astra review passed, including service-level queued/blocked regressions. Production command records were read only; this PR does not clear unresolved commands or activate trading. Cloud Run adoption is not claimed.