Skip to content

fix: select the approved Ready revision for traffic promotion - #338

Merged
Pigbibi merged 2 commits into
mainfrom
fix/concise-runtime-notifications-20260926
Sep 26, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/concise-runtime-notifications-20260926

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep exact commit identity validation during Cloud Run traffic promotion
  • when configuration sync creates a newer Ready revision with an older commit label, select the newest Ready revision that matches the approved commit
  • fail closed when no Ready revision matches

Verification

  • 24 deployment reconciliation tests passed
  • Ruff passed
  • git diff --check passed

Incident evidence

Production run 36250532668 built and verified the approved image, then failed traffic promotion because latestReadyRevisionName pointed at the configuration-sync revision labeled with the previous commit.

Pigbibi and others added 2 commits September 26, 2026 22:48
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit e0043ca into main Sep 26, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/concise-runtime-notifications-20260926 branch September 26, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant