Skip to content

fix: identify account facts HTTP client explicitly - #333

Merged
Pigbibi merged 1 commit into
mainfrom
codex/binance-explicit-http-client-20261003
Oct 2, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
codex/binance-explicit-http-client-20261003

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add the explicit QSL client User-Agent to the isolated facts POST and readiness GET.
  • Keep the endpoint, authentication, validation, acknowledgement rules, timeout, no-redirect policy, and single-request behavior unchanged.
  • Preserve the frozen production caller/application and environment protection.

Evidence

A bounded unauthenticated GET from the existing execution node using the default Python client returned HTTP 403. With only the explicit client header changed, the same endpoint returned the expected HTTP 401 authentication response. This demonstrates a client path difference; actual protected publishing remains to be verified.

Validation

129 targeted synthetic tests passed. Ruff and git diff checks passed. Tests assert the exact endpoint, method, User-Agent, timeout, no redirect handler, and one request.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 0182b14 into main Oct 2, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/binance-explicit-http-client-20261003 branch October 2, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant