fix: support bounded Unicode wallet asset codes - #330
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Accept native wallet asset codes with 1–128 Unicode code points: ASCII uppercase letters/digits or non-ASCII Unicode letters/numbers. Preserve original strings. Reject controls, whitespace, format characters, punctuation, surrogates, ASCII lowercase, four default-ignorable Hangul fillers, overlong strings and exact duplicates. Existing identity, source, amount, pagination and no-order protections remain.
Evidence
The bounded reader classified the previous failure as a non-ASCII asset-code rejection. Binance documents UTF-8 asset/symbol names: https://github.com/binance/binance-spot-api-docs/blob/master/user-data-stream.md#general-information
Review
Independent focused review passed after closing the invisible-filler case. Fixtures are synthetic. Actual balance publication remains to be validated after adoption; the reader gate is currently disabled.
Verification
197 focused Python account-facts and workflow-security tests passed; Ruff and diff checks passed. Spot, Earn and payload share one validator.