fix: isolate monitor dependency staging from active runtime data - #289
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the monitor setup script to install into an explicitly selected new virtual environment without modifying the active environment or shared QPK mirror. Staging reads the pinned QPK commit through git archive and rejects source, data and existing-environment overlaps, including external data roots and symlink aliases. The default installation path and locked dependency versions stay unchanged.
Validation: 14 deployment-script tests passed before review; after targeted fixes, the combined staging regression passed again, covering external data roots and a timeout-protected missing relative-root case. Bash syntax, Ruff and diff checks passed. Astra independently reviewed the changes and verified the final path guard in memory.
This prepares an isolated installation; it does not switch systemd services, install real dependencies or migrate the production venv.