Fix BlockDiag products under JIT and with rectangular blocks - #806
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BlockDiag.mvcreates split indices with JAX array operations. Underjax.jit, these indices become tracers andjnp.splitraisesConcretizationTypeError. It also uses output dimensions to split the input vector, which fails for rectangular blocks.Use input dimensions and Python cumulative sums to keep split indices static. The operator still applies each block separately. Add a release note and tests against dense block-diagonal products and gradients with respect to the blocks and input.
Validation
uv run --no-sync poe test, withPYTHONUTF8=1: 3,245 passed, 1 skipped.uv run --no-sync poe formatandpoe lint: passed.GPU and the full documentation build were not run locally.
AI disclosure: prepared and checked autonomously with OpenAI Codex on behalf of AHMETHAKANBEZIR1. No human review claim is made.