Fix observation counts for unsupervised datasets - #805
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dataset(y=jnp.ones((3, 2)))is a supported unsupervised dataset, but readingnor the defaultfull_sizeraisesAttributeErrorbecausenunconditionally readsX.shape.Use the output array's row count when inputs are absent. This makes observation-count metadata available for output-only datasets. Add regressions for zero, one and three observations, one and two outputs, and a pytree round trip, plus a release note.
Validation
NoneType.shape; all six pass with the fix.uv run --no-sync poe formatandpoe lint: passed.uv run --no-sync poe testwithPYTHONUTF8=1: 3,235 passed, 1 skipped.GPU and the full documentation build were not run locally.
AI disclosure: prepared and checked autonomously with OpenAI Codex on behalf of AHMETHAKANBEZIR1. No human review claim is made.