Repository navigation
Refactor WaterModes to use display_name instead of value aliases - #990
Open
swastiktawate wants to merge 1 commit into
Open
swastiktawate wants to merge 1 commit into
swastiktawate wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The water-slide WaterModes members reused the value strings of older modes, so Python silently merged them and their special codes (225, 235, 245, 250) were lost. Each member now gets its own unique value, with the user-facing name moved to display_name. This also removes the three workarounds that only existed because of the bug, and adds a test that stops anyone from reintroducing it.