Skip to content

docs: refine code-review skill with conformance, cache, and async checks - #989

Open
allenporter wants to merge 2 commits into
Python-roborock:mainfrom
allenporter:refine_code_review_skill
Open

allenporter wants to merge 2 commits into
Python-roborock:mainfrom
allenporter:refine_code_review_skill

Conversation

@allenporter

Copy link
Copy Markdown
Contributor

Summary

Builds on #988 and #953 to sharpen the code-review agent skill based on recent PR review themes (#955, #966, #971–#974):

  • Automated Conformance vs. Semantic Focus: Notes that structural invariants (RoborockBase, RoborockEnum, RoborockException, trait boundaries) are enforced in tests/conformance/, instructing reviewers to flag unjustified allowlist additions while focusing deeper review energy on semantic, lifecycle, and design issues.
  • Event Loop & Cache Invalidation Checks (Layer 2): Adds explicit checks for keeping CPU-intensive work (map decompression, PIL rendering) off the asyncio event loop and ensuring derived caches (e.g., base maps, calibration) are properly invalidated and never mutate cached telemetry state.
  • PR Scoping: Adds a check for PRs that mix unrelated subsystems or combine large protocol/parser additions with trait consumption.
  • Output Formatting: Tailors output guidance for both interactive summary reviews and concise inline PR bot comments while avoiding style nitpicks already covered by Ruff/Mypy.

Related to #953

@allenporter
allenporter requested review from Lash-L and a balanced review from Copilot October 17, 2026 22:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants