Repository navigation
docs: refine code-review skill with conformance, cache, and async checks - #989
Open
allenporter wants to merge 2 commits into
Open
allenporter wants to merge 2 commits into
allenporter wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #988 and #953 to sharpen the
code-reviewagent skill based on recent PR review themes (#955, #966, #971–#974):RoborockBase,RoborockEnum,RoborockException, trait boundaries) are enforced intests/conformance/, instructing reviewers to flag unjustified allowlist additions while focusing deeper review energy on semantic, lifecycle, and design issues.asyncioevent loop and ensuring derived caches (e.g., base maps, calibration) are properly invalidated and never mutate cached telemetry state.Related to #953