Repository navigation
refactor(map): move Q10 rasterization from parser into render module - #986
Draft
allenporter wants to merge 1 commit into
Draft
allenporter wants to merge 1 commit into
allenporter wants to merge 1 commit into
Conversation
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves Q10 map rasterization and palette building out of
roborock.map.b01_q10_map_parserand intoroborock.map.b01_q10_renderso that:b01_q10_map_parseris strictly responsible for decoding wire packets (bytes->Q10MapPacket/Q10TracePacket) without PIL orvacuum_map_parser_basedependencies.b01_q10_renderowns the complete rendering pipeline (Q10MapPacket->MapData/ PNGbytes), eliminating the redundantB01Q10MapParserwrapper class that was only called directly by tests.