Repository navigation
feat: register P30 Pro and decode water and dock status - #983
Open
eggleader-zhang wants to merge 1 commit into
Open
eggleader-zhang wants to merge 1 commit into
eggleader-zhang wants to merge 1 commit into
Conversation
Register the confirmed roborock.vacuum.a306 model and dock type 49. Decode smart-water status code 210 through the existing slider helper. Reuse device and product fixtures for status tests and capability snapshots. AI disclosure: These code and test changes were generated and edited by OpenAI Codex using user-provided device data and app observations. Validation: Pre-commit checks passed. The default test suite passed with 1473 tests and 99 snapshots; 11 real-broker MQTT tests were excluded.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Roborock P30 Pro (
roborock.vacuum.a306) with an automatic water supply and drainage dock reportsdock_type=49andwater_box_mode=210when smart water is selected. The dock code currently falls back tounknown, and the water-slider name helper returnsNonefor this setting.This change registers the confirmed model and decodes these observed status values through the existing mappings.
Changes
ROBOROCK_P30_PROand include it inSUPPORTED_VACUUMS.type_49_dock, following the numeric naming used for docks whose internal name is not confirmed.WaterModes.SMART_WATERfor code210and handle it inget_water_slide_mode_name().Device evidence
roborock.vacuum.a306; firmware:02.23.52; protocol:1.0.V4.74.02(1).fan_power=103,mop_mode=300,dock_type=49.water_box_mode210smart_water230gentle(existing slider mapping)The smart-water sample was captured in general vacuum-and-mop mode, independently of SmartPlan. Existing control payloads and product-nickname mappings are unchanged; this change does not add new dock commands.
Validation
AI disclosure
The code, tests, and this description were generated and edited with OpenAI Codex using user-provided device data and app observations.