Repository navigation
fix: relax boto3/botocore upper-bound pin to avoid dependency conflicts - #153
Conversation
The <1.38 ceiling was stale and started conflicting with other Home Assistant integrations (e.g. LLM Vision) that require a newer boto3 with no upper bound, causing HA's requirements installer to fail setup entirely with RequirementsNotFound for any integration that depends on this package. The AWS Cognito IdP auth calls this library relies on (InitiateAuth/RespondToAuthChallenge) are stable across boto3/botocore versions, so there's no need to cap it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Have you tested home assistant with this update in place. Ive seen issues before when trying to upgrade the boot libray |
|
Yes, been running it for a couple of months. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #153 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 30 30
Lines 2571 2571
Branches 297 297
=======================================
Hits 2570 2570
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Verdict: blocking issue — this reintroduces a previously-fixed regression. Bugs / blocking
Other findingsNone — this is a one-line dependency change with no code, test, or public-API impact. Not reviewedN/A — the diff is limited to |
|
Following up on the automated review above: its "blocking" verdict is out of date, and this change is correct. The
So the Thanks @nsleigh, and for confirming it has been running fine for a couple of months. (Posted with Claude Code; the review bot will also be updated to check HA's dependency constraints on dependency changes.) |
The review blocked #153 based on #136's history, but Home Assistant has since moved to aiobotocore 3.x and pins boto3/botocore==1.42.97 in package_constraints.txt. For dependency changes, fetch HA's current constraints and requirements before judging version ranges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
<1.38ceiling onboto3/botocorewas stale and started conflicting with other Home Assistant integrations (e.g. LLM Vision) that require a newer boto3 with no upper bound, causing HA's requirements installer to fail setup entirely withRequirementsNotFoundfor any integration depending on this package.InitiateAuth/RespondToAuthChallenge) are stable across boto3/botocore versions, so there's no need to cap it.Test plan
pip installresolves cleanly alongside a newer boto3-pinning integration (e.g. LLM Vision)🤖 Generated with Claude Code