Skip to content

fix(ui): docstrings, kwargs and overloads - #3337

Open
vmphase wants to merge 20 commits into
masterfrom
fix/3331
Open

fix(ui): docstrings, kwargs and overloads#3337
vmphase wants to merge 20 commits into
masterfrom
fix/3331

Conversation

@vmphase

@vmphase vmphase commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@vmphase
vmphase requested review from a team and VincentRPS August 7, 2026 09:25
@vmphase
vmphase requested review from DA-344 and plun1331 August 7, 2026 09:25
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Aug 7, 2026
@vmphase
vmphase requested a review from JustaSqu1d August 7, 2026 09:25
@vmphase
vmphase requested a review from a team as a code owner August 7, 2026 09:25
@pycord-app

pycord-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3337/head:pr-3337
git checkout pr-3337

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3337/head

@Paillat-dev Paillat-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog should not be this specific, and should focus on what was fixed/modified and not why & how.

Comment thread discord/ui/checkbox.py
Comment thread discord/ui/checkbox_group.py
@vmphase
vmphase requested a review from Paillat-dev August 9, 2026 19:53
ToothyDev
ToothyDev previously approved these changes Aug 9, 2026
Comment thread CHANGELOG.md Outdated
@vmphase
vmphase dismissed stale reviews from ToothyDev and NeloBlivion via 67482ee August 10, 2026 15:47
Co-authored-by: Paillat <me@paillat.dev>
@vmphase vmphase changed the title fix(ui): accept None for required/default and correct Label kwarg fix(ui): docstrings, kwargs and overloads Aug 10, 2026
@vmphase
vmphase requested a review from ToothyDev August 10, 2026 15:57
Paillat-dev
Paillat-dev previously approved these changes Aug 10, 2026

@Paillat-dev Paillat-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic lgtm pending suqid for changelog here bc I'm not convinced but also idk better

ToothyDev
ToothyDev previously approved these changes Aug 10, 2026
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: Michael <vmphase.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Label.set_radio_group() option kwarg typo

6 participants