feat: File type filtering for Attachment options and FileUpload component by NeloBlivion · Pull Request #3284 · Pycord-Development/pycord

NeloBlivion · 2026-06-23T04:23:58Z

Summary

Support file_types in Option and FileUpload.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.
AI Usage has been disclosed.
- If AI has been used, I understand fully what the code does

pycord-app · 2026-06-23T04:24:01Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3284/head:pr-3284
git checkout pr-3284

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3284/head

Soheab · 2026-07-26T10:25:55Z

+    .. attribute:: image
+
+        Allow image files. This includes ``.png``, ``.gif``, ``.jpg``, ``.jpeg``, ``.jfif``, ``.webp``, and ``.avif``.
+
+    .. attribute:: video
+
+        Allow video files. This includes ``.mp4``, ``.mov``, ``.qt``, and ``.webm``.
+
+    .. attribute:: audio
+
+        Allow audio files. This includes ``.mp3``, ``.m4a``, ``.wav``, ``.ogg``, ``.opus``, and ``.flac``.


Documented twice? Docstring in the class too. Not sure if that's even considered.

The one in the codebase helps IDEs, but this one actually adds to the documentation website, I suppose.

Soheab · 2026-07-26T10:29:38Z

+                    raise TypeError(
+                        "items in file_types must be of type str or FileType"
+                    )
+                if len(str(f)) > 16:


This also checks the length of our enum values, which is a bit useless?

vmphase

Missing changelog.

vmphase · 2026-07-31T19:37:48Z

            payload["required"] = self.required

+        if self.file_types:
+            payload["file_types"] = [str(f) for f in self.file_types]


str(FileType) won't serialize correctly, since it subclasses Enum. Either make it subclass StrEnum, or explicitly serialize with .value when the item is a FileType.

make it a string enum

vmphase · 2026-07-31T19:38:36Z

        if self.max_length is not None:
            as_dict["max_length"] = self.max_length
+        if self.file_types:
+            as_dict["file_types"] = [str(f) for f in self.file_types]


str(FileType) won't serialize correctly, since it subclasses Enum. Either make it subclass StrEnum, or explicitly serialize with .value when the item is a FileType.

vmphase · 2026-07-31T19:43:25Z

+        for f in data.get("file_types", []):
+            (
+                self.file_types.append(f)
+                if f not in FileType.__members__
+                else try_enum(FileType, f)
+            )


Not sure the logic here matches what you were planning, unless I missed something. Currently, when f is a known FileType member, it goes into the else branch and calls try_enum(FileType, f), but the result is never appended anywhere, so it's just discarded. Only unknown values are in self.file_types.

vmphase · 2026-07-31T19:46:51Z

        Whether the file upload field is required or not. Defaults to ``True``.
    id: Optional[:class:`int`]
        The file upload field's ID.
+    file_types: List[:class:`str`, :class:`FileType`]


List[X, Y] is not valid, because it only takes one type parameter.

Suggested change

file_types: List[:class:`str`, :class:`FileType`]

file_types: List[Union[:class:`str`, :class:`FileType`]]

vmphase · 2026-07-31T19:47:54Z

        The maximum number of files that can be uploaded.
    required: Optional[:class:`bool`]
        Whether the file upload field is required or not. Defaults to `True`.
+    file_types: List[:class:`str`, :class:`FileType`]


List[X, Y] is not valid, because it only takes one type parameter.

Suggested change

file_types: List[:class:`str`, :class:`FileType`]

file_types: List[Union[:class:`str`, :class:`FileType`]]

vmphase · 2026-07-31T19:48:06Z

    description_localizations: Dict[:class:`str`, :class:`str`]
        The description localizations for this option. The values of this should be ``"locale": "description"``.
        See `here <https://docs.discord.com/developers/reference#locales>`_ for a list of valid locales.
+    file_types: List[:class:`str`, :class:`FileType`]


List[X, Y] is not valid, because it only takes one type parameter.

Suggested change

file_types: List[:class:`str`, :class:`FileType`]

file_types: List[Union[:class:`str`, :class:`FileType`]]

Lulalaby

can we potentially add a check if the provided file type string starts with .?

vmphase · 2026-07-31T20:00:23Z

can we potentially add a check if the provided file type string starts with .?

Was just typing that, you were faster
=)
Currently garbage like "hello" up to 16 characters passes the validation, even though the docs say "dot-prefixed extensions".

JustaSqu1d · 2026-08-11T06:37:21Z

        The description localizations for this option. The values of this should be ``"locale": "description"``.
        See `here <https://docs.discord.com/developers/reference#locales>`_ for a list of valid locales.
+    file_types: List[:class:`str`, :class:`FileType`]
+        The file types allowed for this option. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).


Suggested change

The file types allowed for this option. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).

The file types allowed for this option. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g., ``".pdf"``).

JustaSqu1d · 2026-08-11T06:39:42Z

+        Only applies to Options with an :attr:`input_type` of :class:`Attachment`.
+
+        .. warning::
+            This only checks the file extension - you will still need to validate the file contents yourself.


Suggested change

This only checks the file extension - you will still need to validate the file contents yourself.

This only checks the file extension. You will still need to validate the file contents.

JustaSqu1d · 2026-08-11T06:39:55Z

+        A maximum of 10 file types can be provided, up to 16 characters each.
+
+        .. warning::
+            This only checks the file extension - you will still need to validate the file contents yourself.


JustaSqu1d · 2026-08-11T06:40:02Z

    id: Optional[:class:`int`]
        The file upload field's ID.
+    file_types: List[:class:`str`, :class:`FileType`]
+        The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).


Suggested change

The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).

The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g., ``".pdf"``).

JustaSqu1d · 2026-08-11T06:40:18Z


+    @property
+    def file_types(self) -> list[str | FileType]:
+        """The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).


Suggested change

"""The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).

"""The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g., ``".pdf"``).

JustaSqu1d · 2026-08-11T06:40:25Z

+        A maximum of 10 file types can be provided, up to 16 characters each.
+
+        .. warning::
+            This only checks the file extension - you will still need to validate the file contents yourself.


JustaSqu1d · 2026-08-11T06:40:41Z

+        The file types allowed in this upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).
+        A maximum of 10 file types can be provided, up to 16 characters each.
+
+        .. warning::
+            This only checks the file extension - you will still need to validate the file contents yourself.


JustaSqu1d · 2026-08-11T06:42:23Z

+    .. attribute:: image
+
+        Allow image files. This includes ``.png``, ``.gif``, ``.jpg``, ``.jpeg``, ``.jfif``, ``.webp``, and ``.avif``.
+
+    .. attribute:: video
+
+        Allow video files. This includes ``.mp4``, ``.mov``, ``.qt``, and ``.webm``.
+
+    .. attribute:: audio
+
+        Allow audio files. This includes ``.mp3``, ``.m4a``, ``.wav``, ``.ogg``, ``.opus``, and ``.flac``.


The one in the codebase helps IDEs, but this one actually adds to the documentation website, I suppose.

JustaSqu1d · 2026-08-11T06:42:52Z

+    .. attribute:: image
+
+        Allow image files. This includes ``.png``, ``.gif``, ``.jpg``, ``.jpeg``, ``.jfif``, ``.webp``, and ``.avif``.
+
+    .. attribute:: video
+
+        Allow video files. This includes ``.mp4``, ``.mov``, ``.qt``, and ``.webm``.
+
+    .. attribute:: audio
+
+        Allow audio files. This includes ``.mp3``, ``.m4a``, ``.wav``, ``.ogg``, ``.opus``, and ``.flac``.


Suggested change

.. attribute:: image

Allow image files. This includes ``.png``, ``.gif``, ``.jpg``, ``.jpeg``, ``.jfif``, ``.webp``, and ``.avif``.

.. attribute:: video

Allow video files. This includes ``.mp4``, ``.mov``, ``.qt``, and ``.webm``.

.. attribute:: audio

Allow audio files. This includes ``.mp3``, ``.m4a``, ``.wav``, ``.ogg``, ``.opus``, and ``.flac``.

.. attribute:: image

Allow image files. This includes ``.png``, ``.gif``, ``.jpg``, ``.jpeg``, ``.jfif``, ``.webp``, and ``.avif`` file extensions.

.. attribute:: video

Allow video files. This includes ``.mp4``, ``.mov``, ``.qt``, and ``.webm`` file extensions.

.. attribute:: audio

Allow audio files. This includes ``.mp3``, ``.m4a``, ``.wav``, ``.ogg``, ``.opus``, and ``.flac`` file extensions.

NeloBlivion added 2 commits June 23, 2026 05:13

support file_types on FileUpload and Option

7cf9b67

enum reconvert

c86a40e

NeloBlivion requested review from a team and Paillat-dev June 23, 2026 04:23

github-project-automation Bot added this to Pycord Jun 23, 2026

NeloBlivion requested a review from Lulalaby June 23, 2026 04:24

github-project-automation Bot moved this to Todo in Pycord Jun 23, 2026

NeloBlivion requested a review from a team as a code owner June 23, 2026 04:24

NeloBlivion requested review from JustaSqu1d and Soheab June 23, 2026 04:24

pullapprove4 Bot added the PA: All Contributors pending label Jun 23, 2026

pre-commit-ci Bot and others added 4 commits June 23, 2026 04:24

style(pre-commit): auto fixes from pre-commit.com hooks

f35b0a2

repr

00b0211

set

edac61c

value

6dc69b4

NeloBlivion modified the milestones: 2.9.0, 2.9.0rc1 Jun 23, 2026

NeloBlivion and others added 2 commits June 23, 2026 06:25

validate file_types

868fdf3

style(pre-commit): auto fixes from pre-commit.com hooks

0815760

Soheab added the priority: low Low Priority label Jul 26, 2026

Soheab added feature Implements a feature upcoming discord feature Involves a feature not yet fully released by Discord undocumented discord feature This isn't documented, might not receive support for it! labels Jul 26, 2026

Merge branch 'master' into filetype

1c75396

Soheab reviewed Jul 26, 2026

View reviewed changes

Paillat-dev added hold: testing This pull request requires further testing hold: changelog This pull request is missing a changelog entry labels Jul 26, 2026

Lulalaby added 2 commits July 30, 2026 15:22

Merge branch 'master' into filetype

99dcede

Merge branch 'master' into filetype

e517dec

vmphase requested changes Jul 31, 2026

View reviewed changes

Lulalaby reviewed Jul 31, 2026

View reviewed changes

JustaSqu1d requested changes Aug 11, 2026

View reviewed changes

pullapprove4 Bot removed the PA: All Contributors pending label Aug 11, 2026

	file_types: List[:class:`str`, :class:`FileType`]
	file_types: List[Union[:class:`str`, :class:`FileType`]]

	The file types allowed for this option. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).
	The file types allowed for this option. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g., ``".pdf"``).

	This only checks the file extension - you will still need to validate the file contents yourself.
	This only checks the file extension. You will still need to validate the file contents.

	The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).
	The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g., ``".pdf"``).

	"""The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g. ``".pdf"``).
	"""The file types allowed in this file upload. Supports a mix of :class:`FileType` and dot-prefixed extensions (e.g., ``".pdf"``).

Uh oh!

Uh oh!

Conversation

NeloBlivion commented Jun 23, 2026

Summary

Information

Checklist

Uh oh!

pycord-app Bot commented Jun 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmphase left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lulalaby left a comment

Choose a reason for hiding this comment

Uh oh!

vmphase commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vmphase commented Jul 31, 2026 •

edited

Loading