Repository navigation
Correct the subtree restore section from a FlashBlade check - #57
Merged
Merged
Conversation
A FlashBlade check of the subtree restore section (Purity//FB 4.8.7) found the procedure works but the text was off in places: - .snapshot shows in ls -a at the file system root, and each snapshot directory carries the snapshot's full name. - The nfs4_getfacl/nfs4_setfacl loop drops ACE4_DELETE_CHILD from file ACEs. That is invisible over NFS and to an nfs4_getfacl comparison, but SMB clients see a changed mask. Say so, and give a raw-attribute comparison for Verify. - cp -a carried every ACL byte, audit entries included; rsync -aX carried none and failed partway. Name both, and note the loop writes to LIVE/SUB, so a copy elsewhere needs those pointed at it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertcantu-pure
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A FlashBlade check of the
.snapshotsubtree restore section added in #53 (Purity//FB 4.8.7, Linux kernel NFSv4.1, a 679-object subtree repaired with v0.10.0-rc4) found that the procedure works but the text was wrong in places. This correctsdocs/field-preview/snapshot-runbook.mdto match..snapshotdoes appear inls -aat the file system root, but not in a plainlsor in subdirectories. Each snapshot directory is named<file system>.<suffix>.nfs4_getfaclshows, not the stored bytes. File ACEs loseACE4_DELETE_CHILD(421 of 673 files in the check). Over NFS that changes nothing, but SMB clients see a different mask, and annfs4_getfaclcomparison can't detect it. The section now says so and tells readers with data that SMB clients use to check from an SMB client, or to copy the subtree back. A byte-for-byte restore mode is tracked in Restore ACLs byte for byte from a snapshot path #56.cp -a/cp -r --preserve=allcarried every ACL byte, audit entries included.rsync -aXcarried none and failed partway. The section now also says the loop writes to$LIVE/$SUB, so a copy made elsewhere needs those pointed at it.getfattr -n system.nfs4_acl -e hexcomparison.Verification
origin/main..HEADcommits: clean..snapshot, the loop's skip and new-object handling,cp -a; failed:rsync -aX; not run: the identity-without-audit-bypass case). Detailed evidence is kept internally.getfattrcommand as written. The lab compared raw attributes, but this exact command line wasn't run. It only reads.🤖 Generated with Claude Code