Skip to content

Process: master must be green — branch protection requiring the Compiler gate once #36377 lands, a CI-streak metric in release-readiness, and a rule that a red master blocks all non-fix merges (.github/workflows/compiler-gate.yml, script/release-readiness.sh, CONTRIBUTING.md) #36401

Open

Description

@PurHur

Category

Foundation: · the precondition for every other gate · child of #36379

Why

gh run list --workflow=compiler-gate.yml --branch master --limit 60 → zero successes. The gate has been red for the entire life of the wave-1 work; 131 commits merged on top of it in 24 h. Three different setup breakages (#36143 → #36209 → #36250/#36377) each got "fixed" by a PR that made the next one. Branch protection is off (/branches/master/protection → 404). Every honesty gate the repo has built is moot while red is the normal colour.

Deliverable

  1. After CI: master is unbuildable both from a clean checkout and on already-patched trees — the #36250 guard demands exactly one replaceVariablesByCfgWalk (a correctly patched file has two) and the pass-manager patch no longer lands on old trees, so every AOT build dies in the new light-opt step (script/apply-patches.sh, patches/php-cfg-simplifier-use-chain.patch, patches/php-llvm-module-createfunctionpassmanager.patch) (re-#36250, re-#36213, re-#36229) #36377: enable branch protection on master — required check Compiler gate, require branches up to date, no admin bypass for the fleet identity.
  2. release-readiness --json gains ci_green_streak_days and last_green_master_sha; README snapshot shows it (Add isset() for web superglobals and fix $_GET VM binding #17).
  3. CONTRIBUTING rule: when master is red, only PRs labelled ci-fix merge; the fleet lanes pause other merges (document the mechanism the RunForge harness uses to enforce it).
  4. The Compiler gate itself: Setup and Verdict as separate named steps (CI: finish the truthful-master work — remove || true in ci-memory-env.sh, split setup from verdict steps, cache the dev image, delete the "GitHub Actions is disabled" claims, enable branch protection (re-#36209) #36247 remainder), image cached in GHCR, apply-patches.sh --verify-pristine on all patches, total < 15 min.

Done when

  • Protection enabled; a PR with a red gate cannot be merged (screenshot/API output in the issue)
  • 14 consecutive days of green master recorded by the streak metric

Activity

  1. added
    enhancementNew feature or request
    MOST IMPORTANTThis are the most important targets
    implementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claim
    on Sep 2, 2026
  2. PurHur commented on Sep 3, 2026

    @PurHur
    OwnerAuthor

    claim: maintainer — master inventory --check is red (8083→8085 after ComposerVendorMap/SpineChunkOnDemandBind). Syncing docs/bootstrap-inventory.md and verifying north-star5-verify-fast this run.

  3. PurHur commented on Sep 3, 2026

    @PurHur
    OwnerAuthor

    Merged inventory/docs sync (Part of #36401): bootstrap-inventory 8086/8086, capabilities + opcode corpus refreshed; CONTRIBUTING red-master / ci-fix rule. north-star5-verify-fast / aot-smoke green locally. Branch protection + 14-day streak still open.

  4. PurHur commented on Sep 3, 2026

    @PurHur
    OwnerAuthor

    Correction: prior comment was premature — PR create failed on missing ci-fix label. Opening the PR now without that label.

  5. PurHur commented on Sep 3, 2026

    @PurHur
    OwnerAuthor

    Merged #36446 — Part of #36401. Inventory 8086/8086 + capabilities/opcode corpus synced; CONTRIBUTING red-master rule. Branch protection / 14-day streak still open.

  6. PurHur commented on Sep 4, 2026

    @PurHur
    OwnerAuthor

    claim: cursor-agent maintainer — continuing #36401 this run. #36143/north-star5-verify-fast green locally; Compiler gate red on master (179/183 VM differential). Fixing the 4 DIFFs that keep master red.

  7. PurHur commented on Sep 4, 2026

    @PurHur
    OwnerAuthor

    Merged #36584 (Part of #36401)

    Compiler gate was 179/183 on master. Fixed the four VM DIFFs:

    • i11 foreach-by-ref: FE_RESET_RW rebind now updates ancestor frame iterators (was destroying live HT via double delRef of the ITER_RESET snapshot)
    • exp_llvm / gc_registry_grow / i36081: case harness honesty

    Verified locally: VM differential 183/183, north-star5-verify-fast OK, apply-patches.sh OK. Branch protection / 14-day streak still open on this issue.

  8. PurHur commented on Sep 4, 2026

    @PurHur
    OwnerAuthor

    claim: cursor-agent maintainer — continuing #36401 this run. #36143 closed; apply-patches + north-star5-verify-fast OK locally. Compiler gate still red: bench-gate IR (simple +23.1%, Ack +28.6% vs baseline). Fixing IR regression / baseline honesty so master can go green.

  9. 391 remaining items

  10. PurHur commented on Sep 9, 2026

    @PurHur
    OwnerAuthor

    Maintainer tip-ratchet landed: #37685 → ed8b3f979f.

    Verified on tip 2e7940d360 (local Docker, $HARNESS_DOCKER_RUN_OPTS):

    Also closed DIRTY IR-stock PR #37682 (pow 96–99 split-TU) — not merging further spine TU fill this lane.

  11. PurHur commented on Sep 9, 2026

    @PurHur
    OwnerAuthor

    claim: cursor-agent maintainer — this run. #36143 closed/green (apply-patches --verify-pristine php-llvm 27/27, structgep OK). Verified on prior tip af346046f4: north-star5-verify-fast OK, aot-smoke 9/9, inventory 8596/8596. Fast-forwarding to tip and re-verifying for tip-ratchet; no IR stock.

  12. added a commit that references this issue on Sep 9, 2026
  13. PurHur commented on Sep 9, 2026

    @PurHur
    OwnerAuthor

    Merged #37696 (Part of #36401) — maintainer tip-ratchet.

    Verified on c689bf3c98

    No open worker PRs this run. #36143–#36148 / #36142 already closed. No IR stock. Streak → last_green_master_sha=c689bf3c98, streak_days=6.

  14. PurHur commented on Sep 9, 2026

    @PurHur
    OwnerAuthor

    claim: cursor-agent maintainer — this run. #36143 closed/green (apply-patches exits 0). Tip at 540eefdb3318: verifying apply-patches --verify-pristine, aot-smoke, north-star5-verify-fast for tip-ratchet; no IR stock.

  15. added a commit that references this issue on Sep 9, 2026
  16. PurHur commented on Sep 9, 2026

    @PurHur
    OwnerAuthor

    Merged #37699 (Part of #36401) — maintainer tip-ratchet.

    Verified on 540eefdb33

    No open worker PRs at merge time (#37697 already on master). #36143–#36148 / #36142 already closed. No IR stock.

  17. PurHur commented on Sep 9, 2026

    @PurHur
    OwnerAuthor

    claim: cursor-agent maintainer — this run. #36143 closed/green (vendor structGep assert present). Tip at 7300b18e64 (+4 since last streak 540eefdb33): verifying apply-patches --verify-pristine, aot-smoke, north-star5-verify-fast for tip-ratchet; no IR stock.

  18. PurHur commented on Sep 14, 2026

    @PurHur
    OwnerAuthor

    claim: cursor-agent maintainer — this run. #36143 closed/green (script/apply-patches.sh exits 0; structgep skip OK). No open PRs. Tip at 2edb1ae925 (+2 since last streak 540eefdb33): verifying apply-patches --verify-pristine, aot-smoke, north-star5-verify-fast (Docker+LLVM) for tip-ratchet; no IR stock.

  19. PurHur commented on Sep 18, 2026

    @PurHur
    OwnerAuthor

    claim: maintainer — this run. No open PRs; #36143–#36148 closed. Verifying apply-patches + aot-smoke + north-star5-verify-fast on tip 99ee8166c2, then tip-ratchet docs/ci-streak.json (#36401). No IR stock.

  20. added a commit that references this issue on Sep 18, 2026
  21. PurHur commented on Sep 18, 2026

    @PurHur
    OwnerAuthor

    Maintainer verify 2026-09-18 (this run):

  22. PurHur commented on Sep 18, 2026

    @PurHur
    OwnerAuthor

    claim: maintainer — this run. Open PRs: 0. #36143–#36148/#36142 closed. Verified script/apply-patches.sh + make north-star5-verify-fast OK on prior tip (structgep/#36143 remains green). Tip now 59ef50766c (bench-only delta): finishing aot-smoke + inventory sync + tip-ratchet (#36401). No IR stock.

  23. added a commit that references this issue on Sep 18, 2026
  24. PurHur commented on Sep 18, 2026

    @PurHur
    OwnerAuthor

    Maintainer verify+merge 2026-09-18 (this run):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    MOST IMPORTANTThis are the most important targetsarea:toolingTooling / CI / docsenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions