fix(ocean/tmaze): migrate binding.c from env_binding.h to vecenv.h API - #658
Open
Battleplus wants to merge 2 commits into
Open
fix(ocean/tmaze): migrate binding.c from env_binding.h to vecenv.h API#658Battleplus wants to merge 2 commits into
Battleplus wants to merge 2 commits into
Conversation
Add required num_agents and rng fields to TMaze struct. Change actions/terminals from int*/uchar* to float* to match vecenv.h buffer ownership. Remove allocate_TMaze from my_init since vecenv manages observation/action/reward/terminal buffers. Fix dict_get call to use ->value accessor (2-arg API). Cast float actions to int in c_step for discrete action handling. Fixes PufferAI#542 (tmaze environment only) 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate tmaze environment from the deprecated
env_binding.hAPI to the currentvecenv.hAPI.Why
The tmaze environment uses
env_binding.hwhich no longer exists in PufferLib 4.0, causing compilation errors:How
vecenv.hinstead ofenv_binding.hdict_get()for reading kwargs (size parameter)dict_set()for exporting log valuesPyObject*typesTesting
ocean/target/binding.cFixes #542 (for tmaze environment)