Skip to content

feat(details): put the age certification in a rounded chip - #644

Open
ReichiMD wants to merge 2 commits into
ProdigyV21:mainfrom
ReichiMD:claude/age-certification-chip-7g95j2
Open

feat(details): put the age certification in a rounded chip#644
ReichiMD wants to merge 2 commits into
ProdigyV21:mainfrom
ReichiMD:claude/age-certification-chip-7g95j2

Conversation

@ReichiMD

@ReichiMD ReichiMD commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

What

The age certification on the movie and show details screens is now shown in a
small rounded chip instead of plain text in the metadata row, so it reads as a
certification rather than as one more number next to the runtime. The hero
preview on the TV home screen shows it too — it had the data available but was
not displaying it.

How

  • Reuses the existing "In Cinema" pill pattern from the details screen: Box +
    RoundedCornerShape(6.dp) + padding(horizontal 10.dp, vertical 4.dp), moved to
    ui/components/ContentRatingChip.kt so both screens share one definition.
  • Neutral translucent background, no colour coding by age — deliberately, see
    below.
  • Details screen: applied to both layouts (phone and TV). The separator in front
    of the certification is dropped; the chip separates itself.
  • TV home screen hero: the certification is carried through HeroDetailsSnapshot,
    which already holds the runtime, IMDb rating and budget from the same details
    call — so this costs no additional request.

Notes for review

  • No new strings, no changes to the certification logic or the TMDB models —
    presentation only, apart from the one field added to the hero snapshot.
  • On TV the details metadata row has a fixed width and the genre text ellipsises;
    the chip takes slightly more room than the plain text did. Checked on a TCL C7K.

Deliberately not included

  • No colour by age rating: the age is only unambiguous for a few numeric systems
    (FSK, BBFC, ClassInd, ACB, Kijkwijzer) and would have to be guessed for
    letter-based ones (R, PG-13, TV-MA). A wrong colour is worse than none.
  • Not shown in the phone home carousel: its cards come straight from the category
    rows and carry no certification, so it would mean a details request per card.
    On the phone the certification is on the details screen.
  • No conversion of the remaining metadata (genre, year, runtime) to chips.
  • No skin/theme tokens.

Testing

Built as a sideload debug APK and installed on a phone and on a TCL C7K
(Android TV). Existing unit tests unchanged and green.

PXL_20260904_205556080 MP PXL_20260904_205541332 MP Screenshot_20260904-224951

created by Claude (Anthropic) on behalf of @ReichiMD

ReichiMD and others added 2 commits September 4, 2026 19:02
Show the age certification in a small rounded chip instead of plain text
in the metadata row of the movie and show details screens, so it reads as
a certification rather than as one more value next to the runtime.

Reuses the "In Cinema" pill pattern from the same file (Box +
RoundedCornerShape(6.dp) + padding 10.dp/4.dp) with a neutral translucent
surface instead of a solid colour, and drops the separator in front of the
certification in both layouts - the chip separates itself. Presentation
only: no new strings, no change to the certification logic or the models.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FS332afDiMApwV6SzEpvrf
The hero preview above the rows on the home screen shows date, genre,
runtime and the IMDb rating, but not the age certification, even though
it already loads the full details for the focused item - the certification
was simply not carried through the hero snapshot.

Adds it to HeroDetailsSnapshot so the existing details call is reused (no
extra request) and renders it in the same rounded chip as on the details
screen. The chip moves to ui/components so both screens share one
definition instead of repeating the style.

The phone home screen is deliberately left alone: it uses a carousel whose
cards come straight from the category rows and carry no certification, so
showing it there would mean fetching details per card. On the phone the
certification stays on the details screen.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FS332afDiMApwV6SzEpvrf
@github-actions github-actions Bot added the area: android Changes to the Android app or Gradle build label Sep 4, 2026
@Himanth-reddy

Copy link
Copy Markdown
Collaborator

I like the idea of making the certification more distinct, but I don't think the current chip quite sits right with the existing UI. The metadata row currently has a pretty clean and consistent rhythm with the rating, year and runtime separated by dots, and the chip makes the certification feel a bit visually heavier than the rest. I think it might be worth exploring a treatment that gives the certification some distinction without introducing a full pill/chip into the metadata row.

@ProdigyV21

Copy link
Copy Markdown
Owner

I agree with himmanth, it makes it a bit too heavy. Should be in the same rythm as the rest.

@ReichiMD

ReichiMD commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Yes, I agree with you and I'll take another look at it.👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: android Changes to the Android app or Gradle build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants