i18n(settings): move SettingsViewModel status messages into string resources - #643
Merged
ProdigyV21 merged 1 commit intoSep 5, 2026
Conversation
…sources Moves the hardcoded English toasts, status lines and inline errors produced by SettingsViewModel into the string resource system and adds the German values. The messages are created outside a composable, so they are not resolved in the ViewModel: SettingsUiState now carries a SettingsMessage (a @stringres id plus format args, or raw text for platform exception messages) and SettingsScreen resolves it with stringResource. This mirrors PlayerMessage/PluginMessage and keeps the rendered language tied to the app language instead of the system language of the device. No behaviour changes: stored values, ids and API parameters are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QNcHMnhSphhH3y5JNVSwwS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Same approach as #632, applied to the status and toast messages in
SettingsViewModel.Moves the hardcoded English UI strings in the Settings ViewModel into the string resource
system and adds the German values. No behaviour changes, no logic changes.
toasts, IPTV and Home Server status lines, catalog-pack and catalog-discovery errors,
ARVIO Cloud sign-in/sync feedback, Trakt/Simkl/MDBList feedback
(
settings_waiting_for_approval,settings_cloud_pull_no_backup_toast)values/strings.xmlin a matchingSettingsViewModelsection(the IPTV status line needs two variants each, with and without the EPG summary)
values-de/strings.xmlThese messages are produced outside a composable, so they are not resolved in the ViewModel.
SettingsUiStatenow carries aSettingsMessage— a@StringResid plus format args, orRawtext for platform exception messages — andSettingsScreenresolves it withstringResource. This is the same pattern asPlayerMessage(#641) andPluginMessage(4691412), so the rendered language follows the language selected in the app instead of the
system language of the device. The 49
context.getString(...)calls that already resolvedthese same fields in the ViewModel moved over to that mechanism as well.
Why
Approved in Discord (28 Aug): "Yes try to also bring hardcoded things into this.
That has been kinda a long time bug. They dont have to be in English yea."
This benefits all 50 language folders, not just German — untranslated locales fall
back to English exactly as before.
Notes
Follows the existing pattern from
LiveCategory.kt."Portal 1") is persisted inStalkerPortalEntry, so itstays English on purpose.
untouched.
back from repositories are out of scope; the latter are passed through as
SettingsMessage.Raw.testSideloadDebugUnitTest).Created by Claude (Anthropic) on behalf of @ReichiMD.