i18n(home/search): localize TMDB genre names and discover row titles - #642
Merged
ProdigyV21 merged 1 commit intoSep 5, 2026
Merged
Conversation
Moves the remaining hardcoded English UI strings on the home screen and in search into the string resource system and adds the German values. - TMDB genre names are resolved from the numeric genre id through a shared helper (TmdbGenreNames.kt) so the home metadata rows and the search filter chips no longer keep two separate English copies of the same list - the five discover row titles are localized for display only; the English title stays in Category.title because it is part of the category id - home: "Still loading your catalogue…" (new key), "Retry" (reuses the existing resource) and "No description available." - also fills the seven values-de entries that were missing after the recent IPTV favourites and channel-variant work Stored values, ids and API parameters are unchanged; only rendered text is localized. Follows the existing pattern from LiveCategory.kt. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSCNqHXddqFkQ5XramTXJm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Same approach as #632, applied to the home screen and search.
Moves the remaining hardcoded English UI strings on the home screen and in
search into the string resource system and adds the German values. No
behaviour changes, no logic changes.
HomeScreen.ktand one inSearchViewModel.kt. They now resolve from thenumeric TMDB genre id through a shared helper (
TmdbGenreNames.kt), so thehome metadata rows and the search filter chips read from one place
collections_genre_*resources; 15 arenew keys
Releases, Hidden Gems) are localized for display only
new keys, "Retry" reuses the existing
R.string.retryvalues-deentries that were missing after the recentIPTV favourites and channel-variant work, so the German locale is complete
again
Why
Approved in Discord (28 Aug): "Yes try to also bring hardcoded things into
this. That has been kinda a long time bug. They dont have to be in English
yea."
This benefits all 50 language folders, not just German — untranslated locales
fall back to English exactly as before.
Notes
localized. Follows the existing pattern from
LiveCategory.kt.Category.titleon purpose: it ispart of the category id used as the row's focus key.
were there before, so no item gains or loses a genre label.
COUNTRIES), brand names and animation labels are leftuntouched.
created by Claude (Anthropic) on behalf of @ReichiMD