i18n(home): localize the remaining preinstalled catalog rows - #640
Merged
ProdigyV21 merged 2 commits intoSep 4, 2026
Merged
Conversation
The PIN lock for live TV groups added six English strings that have no German values yet, so German users see them untranslated. This adds the missing values-de entries next to the existing live TV category menu block. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019qpC3iuJJJKj4BDvz89D8z
The home screen already localizes preinstalled catalog rows through localizedCategoryTitle(), keyed by the catalog id. Seven of the twelve preinstalled catalogs were never added to that map, so their rows stayed English in every language: Favorite TV, Sports, Popular Live Sports, Just Added, Top Movies This Week, New in K-Dramas and Coming Soon. They are looked up by CatalogConfig.id, exactly like the rows that were already handled. The stored title in CatalogConfig is untouched, so cloud sync, ordering and the rename detection in CatalogRepository keep comparing the same English defaults they always did. Coming Soon reuses the existing settings_coming_soon resource instead of adding a duplicate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019qpC3iuJJJKj4BDvz89D8z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Same approach as #632, applied to the preinstalled catalog rows on the home screen.
The home screen already localizes preinstalled catalog rows in
localizedCategoryTitle(), keyed byCatalogConfig.id. Seven of the twelvepreinstalled catalogs were never added to that map, so their row headers stayed
English in every language.
stringResource(...): Favorite TV, Sports,Popular Live Sports, Just Added, Top Movies This Week, New in K-Dramas and
Coming Soon
settings_coming_soon) instead ofadding a duplicate key
values/strings.xml, in the existing Home sectionvalues-de/strings.xmlIt also adds the German values for the six live TV group PIN strings that came
in recently and had no
values-deentries yet (live_menu_lock_category,live_menu_unlock_category,live_group_enter_pin,live_group_pin_incorrect,live_group_pin_required_title,live_group_pin_required_message). With those,values-decovers every key invaluesexceptapp_name.Why
Approved in Discord (28 Aug): "Yes try to also bring hardcoded things into this.
That has been kinda a long time bug. They dont have to be in English yea."
This benefits all 50 language folders, not just German — untranslated locales
fall back to English exactly as before.
Notes
CatalogConfig.id, never by the displayed text, so cloud sync, ordering andthe renamed-catalog detection in
CatalogRepositorykeep comparing the sameEnglish defaults they always did. Follows the existing pattern from
LiveCategory.kt.ViewModelpicks up thesystem locale instead of the in-app one.
testSideloadDebugUnitTeston the branch; the build is green.created by Claude (Anthropic) on behalf of @ReichiMD