Skip to content

i18n(home): localize the remaining preinstalled catalog rows - #640

Merged
ProdigyV21 merged 2 commits into
ProdigyV21:mainfrom
ReichiMD:claude/reichimd-i18n-cleanup-hu6j5u
Sep 4, 2026
Merged

i18n(home): localize the remaining preinstalled catalog rows#640
ProdigyV21 merged 2 commits into
ProdigyV21:mainfrom
ReichiMD:claude/reichimd-i18n-cleanup-hu6j5u

Conversation

@ReichiMD

@ReichiMD ReichiMD commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

What

Same approach as #632, applied to the preinstalled catalog rows on the home screen.

The home screen already localizes preinstalled catalog rows in
localizedCategoryTitle(), keyed by CatalogConfig.id. Seven of the twelve
preinstalled catalogs were never added to that map, so their row headers stayed
English in every language.

  • 7 rows now resolve through stringResource(...): Favorite TV, Sports,
    Popular Live Sports, Just Added, Top Movies This Week, New in K-Dramas and
    Coming Soon
  • 1 of them reuses an existing resource (settings_coming_soon) instead of
    adding a duplicate key
  • 6 new keys added to values/strings.xml, in the existing Home section
  • German values added to values-de/strings.xml

It also adds the German values for the six live TV group PIN strings that came
in recently and had no values-de entries yet (live_menu_lock_category,
live_menu_unlock_category, live_group_enter_pin, live_group_pin_incorrect,
live_group_pin_required_title, live_group_pin_required_message). With those,
values-de covers every key in values except app_name.

Why

Approved in Discord (28 Aug): "Yes try to also bring hardcoded things into this.
That has been kinda a long time bug. They dont have to be in English yea."

This benefits all 50 language folders, not just German — untranslated locales
fall back to English exactly as before.

Notes

  • Stored values and internal keys are unchanged. The lookup is by
    CatalogConfig.id, never by the displayed text, so cloud sync, ordering and
    the renamed-catalog detection in CatalogRepository keep comparing the same
    English defaults they always did. Follows the existing pattern from
    LiveCategory.kt.
  • Nothing is resolved outside a composable, so no ViewModel picks up the
    system locale instead of the in-app one.
  • Brand and franchise names (Netflix, Marvel, James Bond, ...) are left untouched.
  • Log messages, telemetry strings and animation labels are out of scope.
  • Verified with testSideloadDebugUnitTest on the branch; the build is green.

created by Claude (Anthropic) on behalf of @ReichiMD

The PIN lock for live TV groups added six English strings that have no
German values yet, so German users see them untranslated. This adds the
missing values-de entries next to the existing live TV category menu block.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019qpC3iuJJJKj4BDvz89D8z
The home screen already localizes preinstalled catalog rows through
localizedCategoryTitle(), keyed by the catalog id. Seven of the twelve
preinstalled catalogs were never added to that map, so their rows stayed
English in every language: Favorite TV, Sports, Popular Live Sports,
Just Added, Top Movies This Week, New in K-Dramas and Coming Soon.

They are looked up by CatalogConfig.id, exactly like the rows that were
already handled. The stored title in CatalogConfig is untouched, so cloud
sync, ordering and the rename detection in CatalogRepository keep comparing
the same English defaults they always did. Coming Soon reuses the existing
settings_coming_soon resource instead of adding a duplicate.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019qpC3iuJJJKj4BDvz89D8z
@github-actions github-actions Bot added the area: android Changes to the Android app or Gradle build label Sep 4, 2026
@ProdigyV21
ProdigyV21 merged commit e122440 into ProdigyV21:main Sep 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: android Changes to the Android app or Gradle build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants