Skip to content

chore(drift-sync): apply template updates from quality-zero-platform - #246

Open
Prekzursil wants to merge 1 commit into
mainfrom
quality-zero/drift-sync/manual
Open

Prekzursil wants to merge 1 commit into
mainfrom
quality-zero/drift-sync/manual

Conversation

@Prekzursil

Copy link
Copy Markdown
Owner

Automated template-drift sync from quality-zero-platform.

Platform ref: bfe19ccfae9d14750647659b84048b6876a3ae4b

Updated files:

  • ci-fragments/setup-node.yml (missing)
  • ci-fragments/setup-python.yml (missing)
  • codecov.yml (missing)
  • coverage-thresholds.json (missing)
  • dependabot.yml (missing)
  • ci.yml (missing)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T06:22:16.796976Z 3c03c1b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread ci.yml
Comment on lines +34 to +44
pwsh -ExecutionPolicy Bypass -File ./tools/quality/collect-dotnet-coverage.ps1 -Configuration Release -DeterministicOnly
$candidates = @(
(Join-Path (Get-Location) 'TestResults/coverage/cobertura.xml'),
(Join-Path (Get-Location) 'tests/SwfocTrainer.Tests/TestResults/coverage.cobertura.xml'),
(Join-Path (Get-Location) 'TestResults/coverage.cobertura.xml')
)
$resolved = $candidates | Where-Object { Test-Path -Path $_ } | Select-Object -First 1
if (-not $resolved) {
throw "Coverage report not found. Checked: $($candidates -join '; ')"
}
Write-Host "Using coverage report: $resolved"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The "Test with coverage" step in ci.yml has broken YAML indentation and attempts to execute PowerShell code under shell: bash.
Severity: LOW

Suggested Fix

Fix indentation for lines 35–44 to align within the run: | block, and change the step's shell to shell: pwsh (or extract the PowerShell commands into a script executed via pwsh).

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: ci.yml#L33-L44

Potential issue: In `ci.yml`, the "Test with coverage" step contains YAML indentation
and shell syntax errors. Lines 35–44 lose the indentation required by the `run: |`
scalar, starting at column 0 with a plain scalar (`$candidates = @(...)`) that causes a
YAML parsing error. Furthermore, lines 35–44 contain PowerShell script syntax while the
step is explicitly configured with `shell: bash`, which would fail execution even if
indentation were resolved.

Did we get this right? 👍 / 👎 to inform future reviews.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c03c1bcf6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ci.yml
@@ -0,0 +1,44 @@
name: .NET WPF CI

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the synced templates to the active GitHub config paths

GitHub Actions discovers workflows under .github/workflows/, so this root-level ci.yml never runs on either of its declared events. At the reviewed commit, .github/workflows/ci.yml still contains the previous pipeline, and a repository-wide reference search found no mechanism that consumes or copies this new file. The same destination problem affects the added root-level dependabot.yml: GitHub continues using the unchanged .github/dependabot.yml, so the new security-update grouping is not applied. Map these templates to their actual configuration destinations and reconcile them with the existing files rather than adding inactive root-level copies.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant