Repository navigation
fix(ci): gate-deps residual-risk entry, Library a11y name, packaged-leg fuse resolution - #546
Conversation
…eg fuse resolution quality (gate-deps): picomatch GHSA-fc5q-39xc-vjpf is unfixable — 4.0.7 is the newest published release and is itself the last affected (ReDoS, dev-scope via tinyglobby/vite/vitest, availability-only). Reasoned [[IgnoredVulns]] entry added per this file's own POLICY; the expired and now-UNUSED GHSA-mh99-v99m-4gvg entry retired with a dated note. Verified locally with the pinned osv-scanner 2.3.8 using the exact CI command: exit 0, 'No issues found'. e2e (a11y): axe 4.14 label-content-name-mismatch (serious) fired on .library__item-open — the card's visible text runs (badges, facts caption, path) render inside the open button but were absent from its aria-label (WCAG 2.5.3). cardAriaLabel now contains every visible run; sourceFormatLabel moved to libraryModel.ts so the caption and the name cannot drift. 127 vitest tests pass locally. e2e (packaged leg): resolves the documented W66 option (b) — CI builds the TEST-ONLY package with --config.electronFuses. enableNodeCliInspectArguments=true + RF_E2E_PACKAGED_INSPECT=1 marker; packaged.spec.ts now ASSERTS the RELEASE config keeps the fuse false and fast-fails without the marker (no more red-by-construction / 900s hang). owner-directed automation; --admin documented
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27f4402dc5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| --win --publish never | ||
| - name: Mark the test-built package (inspect fuse on) | ||
| if: runner.os == 'Windows' | ||
| run: echo "RF_E2E_PACKAGED_INSPECT=1" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Use PowerShell syntax for the package marker destination
On the Windows leg of .github/workflows/e2e.yml, this step uses the default PowerShell shell, where $GITHUB_ENV is an unset ordinary variable rather than the environment-file path. The redirection therefore fails instead of exporting the marker, stopping the job before the packaged tests run. GitHub's documentation confirms that “Windows runners use PowerShell” and require $env:NAME for environment variables. Change the destination to $env:GITHUB_ENV, or explicitly select Bash for this step.
Useful? React with 👍 / 👎.
owner-directed automation; --admin documented
| * the card caption and the card's accessible name so the two cannot drift | ||
| * (WCAG 2.5.3 label-content-name-mismatch). | ||
| */ | ||
| export function sourceFormatLabel(path: string): string { | ||
| const match = /[^/.]\.([A-Za-z0-9]{1,5})$/.exec(path); | ||
| return match ? match[1].toUpperCase() : ''; | ||
| } | ||
|
|
||
| /** The date part (YYYY-MM-DD) of an ISO `addedAt`; '' when unparseable. */ | ||
| export function formatAdded(iso: string): string { | ||
| const m = /^(\d{4}-\d{2}-\d{2})/.exec(iso); |
There was a problem hiding this comment.
Bug: The text components assembled in cardAriaLabel do not match the visual and DOM ordering in LibraryCard, which may fail axe-core's label-content-name-mismatch rule.
Severity: LOW
Suggested Fix
Reorder the text segments in cardAriaLabel within libraryModel.ts to mirror the DOM order in LibraryCard: duration, title, badge chips, path, and facts.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: app/renderer/src/views/libraryModel.ts#L117-L154
Potential issue: In `cardAriaLabel`, the accessible name parts are ordered differently
than the visible text runs in the DOM (`button.library__item-open`). The visible order
runs duration, title, badges, path, and facts, whereas `cardAriaLabel` orders them as
title, badges, duration, status, facts, and path. If axe-core's
`label-content-name-mismatch` rule evaluates the visible label as an ordered substring
rather than individual tokens, the accessible name will fail validation and the CI
accessibility check will stay red.
Did we get this right? 👍 / 👎 to inform future reviews.
The fuses-comment stripper regex had a literal newline byte inside the character class (unparseable — CodeQL and prettier both errored); now the intended /#[^\n]*/g literal. All touched files prettier-clean; 127 tests pass; tsc clean. owner-directed automation; --admin documented
A stray prettier --write (defaults, double quotes) had reformatted the files against this repo's biome config. Re-formatted with biome 2.5.0; 127 tests pass; tsc clean. owner-directed automation; --admin documented
owner-directed automation; --admin documented
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ce62c2b92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| --win --publish never | ||
| - name: Mark the test-built package (inspect fuse on) | ||
| if: runner.os == 'Windows' | ||
| run: echo "RF_E2E_PACKAGED_INSPECT=1" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Use PowerShell syntax to export the packaged-build marker
On the Windows leg of e2e.yml, this step has no shell override, so it runs in PowerShell rather than Bash. GitHub documents PowerShell as the Windows default and uses >> $env:GITHUB_ENV for environment-file writes (shell documentation, environment-file example). Here $GITHUB_ENV is an unset PowerShell variable, so the redirection fails instead of exporting the marker. Consequently, the later Windows Playwright step reaches the new RF_E2E_PACKAGED_INSPECT check in packaged.spec.ts without the marker and throws even if packaging succeeded. Use $env:GITHUB_ENV or explicitly select shell: bash.
Useful? React with 👍 / 👎.
…ures The installer's GitHub-Releases version probe has failed three quality runs on shared runners (44261743120, 44272622961, 44290602996 - 'Error: Failed to fetch available versions from GitHub'), each time as the FIRST failure of an otherwise-green gate. Four attempts with a 20s backoff. owner-directed automation; --admin documented
Three sources of red on main:
.library__item-open: the card's visible text runs (badges, facts caption, path) render inside the open button but were missing from its accessible name (WCAG 2.5.3).cardAriaLabelnow contains every visible run;sourceFormatLabelmoved next to it in libraryModel.ts so caption and name cannot drift. Local: 127 vitest tests pass (libraryModel + LibraryCard + Library).--config.electronFuses.enableNodeCliInspectArguments=true+RF_E2E_PACKAGED_INSPECT=1marker; packaged.spec.ts ASSERTS the RELEASE electron-builder.yml keeps the fuse false and fast-fails without the marker. tsc clean; e2e.yml YAML validated.owner-directed automation; --admin documented