Repository navigation
chore(deps-dev): bump jsdom from 24.1.3 to 30.1.3 in /app - #532
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [jsdom](https://github.com/jsdom/jsdom) from 24.1.3 to 30.1.3. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v24.1.3...v30.1.3) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.1.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab8ac3c3b8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "electron-vite": "^3.1.0", | ||
| "fast-check": "^3.23.2", | ||
| "jsdom": "^24.1.0", | ||
| "jsdom": "^30.1.3", |
There was a problem hiding this comment.
Keep jsdom compatible with the Node 20 test runner
The mandatory quality.yml workflow provisions Node 20, but the resolved jsdom 30.1.3 package declares ^22.22.2 || ^24.15.0 || >=26.0.0 in package-lock.json. Because the Vitest coverage lane loads jsdom for many renderer tests, it now runs outside jsdom's supported runtime and may fail before executing those tests. Keep a Node-20-compatible jsdom release or upgrade the CI and documented development runtime together.
AGENTS.md reference: AGENTS.md:L3-L4
Useful? React with 👍 / 👎.
| "whatwg-url": "^14.0.0", | ||
| "ws": "^8.18.0", | ||
| "tough-cookie": "^6.0.2", | ||
| "undici": "^8.12.1", |
There was a problem hiding this comment.
Let jsdom install its required Undici major
When jsdom exercises XMLHttpRequest or external-resource loading, this declared Undici 8 dependency is not what gets installed: the root overrides entry forces Undici ^6.29.1, and the resulting lockfile contains only 6.29.1. This newly introduced major-version substitution puts jsdom's networking implementation outside its dependency contract even after the Node runtime is upgraded; narrow or update the override so jsdom can receive its required Undici major.
Useful? React with 👍 / 👎.
|
Superseded by #538. |
Bumps jsdom from 24.1.3 to 30.1.3.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
058c0f530.1.3fcd1fd1Cascade parsed longhands independentlya3ee786Cascade computed style properties on demandf42dc15Resolve colors before caching or using currentcolor074b1fbCompute background-position lengths against the final font sized19598cApply style rules nested in multiple@mediarules45d626cRule out attribute selector subjects before matching3ff0a5bUpgrade Undici and remove abort workarounds8813bb1Ignore CSS declarations with unparseable math functions63712d8Fix XHR credentials across redirectsMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for jsdom since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)