Skip to content

Remove dead code from the sandbox request loop - #56

Merged
eliotwrobson merged 1 commit into
mainfrom
claude/remove-dead-handle-client
Nov 18, 2026
Merged

eliotwrobson merged 1 commit into
mainfrom
claude/remove-dead-handle-client

Conversation

@eliotwrobson

Copy link
Copy Markdown
Collaborator

Cleanup only, no behavior change. handle_client carried leftovers from an early prototype:

  • a ~20-line commented-out request handler above the real try block;
  • an unreachable if line.lower() == "exit" branch that wrote "Goodbye!" — the grader protocol has no such message and the client never sends it;
  • a couple of placeholder comments (# Simulate processing a request, etc.).

Testing

mypy, ruff and the full test suite (322 passed) are clean.

🤖 Generated with Claude Code

Drop a commented-out request handler left from an early prototype, the
unreachable "exit" command branch (the grader never sends it), and stray
placeholder comments in handle_client.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@eliotwrobson
eliotwrobson marked this pull request as ready for review November 18, 2026 22:19
@eliotwrobson
eliotwrobson merged commit c5e0ec3 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant