Repository navigation
Stop student code from reading the test files - #53
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run.shstopped the sandbox user from changing/grade/run, but everything stayed world-readable. Student code could readtest_student.py,leading_code.pyand anything else intests/, such as expected values or reference code, withio.openorimportlib.machinery.SourceFileLoader(...).get_data(...).Now everything under
/grade/runis owner-only (root), exceptstudent/. The sandbox user can still pass through the folders to reachstudent/, which workspace mode imports from. The grader reads leading code, setup code, helper modules and data files, and hands them to the sandbox, so none of them need to be readable by it. Group permissions are removed too, because the sandbox keeps root's supplementary groups.Testing
I ran jobs in the released image and in an image with the new
run.sh, with/gradecopied into the container. Docker Desktop on macOS doesn't enforce permissions on bind mounts, so a mounted/gradecan't show the difference./grade/run/test_student.pyfrom student code: released image returns the contents, new image raisesPermissionError. The student can still read their own files.workspace_exec_entry) passes in both images.🤖 Generated with Claude Code