Repository navigation
Use pytest's importlib import mode by default - #50
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotwrobson
marked this pull request as ready for review
November 18, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9. Every question's tests are in
test_student.py. pytest's defaultprependimport mode imports each one as the moduletest_student, so running pytest over several questions stops with an "import file mismatch" error. The plugin now sets--import-mode=importlib, which names each module by its path. It leaves the mode alone if the user chose one, on the command line, inaddoptsor inPYTEST_ADDOPTS.In the grader image there's one
test_student.py, so the only change there is that/grade/runisn't put onsys.path. Nothing should rely on that:test_student.pyalready can't import the other files intests/.Testing
Installed this branch in the grader image and graded several example questions: codeEditor (correct and timing out), randomFunctionName, fillBlankLastElement, and a question that imports a
serverFilesCoursemodule from the tests, setup code and student code. Scores matched the current image.🤖 Generated with Claude Code