Repository navigation
Let setup code import server params - #47
Merged
Merged
Conversation
…erver_data Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotwrobson
marked this pull request as ready for review
November 18, 2026 08:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5. Setup code can now import
data["params"]instead of reading the injected__data_paramsand__from_server_jsonglobals, which IDEs and linters flag as undefined:sys.modules, whatever the whitelist and blacklist say.import pytest_prairielearn_grader.server_dataandfrom pytest_prairielearn_grader import server_datawork too.ImportError, so student code still can't read the params.paramsoutside the sandbox, for example in a test, raises an error that points to thedata_jsonfixture.__data_paramsand__from_server_jsonstill work, so existing questions don't change. The docs now use the import.This doesn't add the issue's
server_data.seedattribute access. IDEs can't check those names either way, andparams["seed"]keeps a single way to read them. It would be a small module__getattr__if we want it.🤖 Generated with Claude Code