Conversation
Documents the typed-judgment endpoint added to the gateway (TypeSafe's Jev is the first supported provider, with more planned): path, request/response schemas, tag, and code-samples navigation entry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Three moderate OpenAPI schema issues remain unresolved.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds the /v1/decisions typed-judgment OpenAPI endpoint and related schemas.
Changes:
- Adds endpoint metadata, authentication, examples, and response schemas.
- Adds typed question and answer schemas.
- Adds the Decisions tag and documentation navigation.
Three moderate schema issues remain regarding required fields and discriminated unions.
| File | Description |
|---|---|
openapi.yaml |
Defines the Decisions endpoint, schemas, examples, and documentation metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+26404
to
+26411
| type: | ||
| description: | | ||
| The kind of typed answer to return: | ||
| - `noul`: a single number. | ||
| - `choice`: one of the labels defined in `criteria`. | ||
| - `score`: a score between 0 and 1, optionally labeled by `criteria`. | ||
| type: string | ||
| enum: [noul, choice, score] |
Comment on lines
+26475
to
+26478
| required: | ||
| - state | ||
| - model | ||
| - questions |
2 of 5 tasks
2 of 4 tasks
vrv-panw
approved these changes
Sep 29, 2026
1 of 2 tasks
sk-portkey
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/decisionstyped-judgment endpoint: path definition,CreateDecisionsRequest/CreateDecisionsResponseschemas, and theDecisionsQuestion/DecisionsAnswer(noul/choice/score discriminated union) component schemas.Decisionstag and anx-code-samples.groupsnavigation entry, following the repo's documented convention for new endpoints.src/types/decisionsRequestBody.tsingateway-enterprise-node), not assumptions.Test plan
python3 -c "import yaml; yaml.safe_load(open('openapi.yaml'))"parses cleanly/v1/decisionsroute ingateway-enterprise-node🤖 Generated with Claude Code