Bukkit 26.1.2

[ArikSquad]

Pull Request

Description

This PR implements Minecraft versions from 26.1.2 through 26.3. I've decided that maybe it's best for just Bukkit to be implemented here in a single PR. I've also included a hack due to some changes with Bukkit#createBlockData, and I have since added entity SNBT features to this.

Changelog

• 26.1.2 and 26.3 support

Checklist

Mandatory checks

• The base branch of this PR is an unreleased version branch (that has a ver/ prefix)
  or is a branch that is intended to be merged into a version branch.
• There are no already existing PRs that provide the same changes.
• The PR is within the scope of Terra (i.e. is something a configurable terrain generator should be doing).
• Changes follow the code style for this project.
• I have read the CONTRIBUTING.md
  document in the root of the git repository.
• LLM-based tools were not used to create this PR. (ChatGPT, Claude, etc)

Types of changes

• Bug Fix
• Build system
• Documentation
• New Feature
• Performance
• Refactoring
• Repository
• Revert
• Style
• Tests
• Translation

Compatibility

• Introduces a breaking change
• Introduces new functionality in a backwards compatible way.
• Introduces bug fixes

Documentation

• My change requires a change to the documentation.
• I have updated the documentation accordingly.

Testing

• I have added tests to cover my changes.
• All new and existing tests passed.

Licensing

• I am the original author of this code, and I am willing to
  release it under GPLv3.
• I am not the original author of this code, but it is in public domain or
  released under GPLv3 or a compatible license.

[hui14]

Hello, I am trying to enable this Terra on version 26.2. It throws a NoSuchMethodException during enabling, attempting to call CraftItemStack.asBukkitCopy(net.minecraft.world.item.ItemStack) via reflection, but this method signature does not exist in the server core. However, on version 26.1.2, it works fine. Is this version really compatible with 26.2? If so, how can I make it work?

[ArikSquad]

Hello, I am trying to enable this Terra on version 26.2. It throws a NoSuchMethodException during enabling, attempting to call CraftItemStack.asBukkitCopy(net.minecraft.world.item.ItemStack) via reflection, but this method signature does not exist in the server core. However, on version 26.1.2, it works fine. Is this version really compatible with 26.2? If so, how can I make it work?

It seems like this is an issue in the upstream cloud command framework from what I'm reading. We can't really fix that without patching the framework itself, and the framework seems to have become unmaintained which means that a PR there probably wouldn't result in it getting merged. I'd have to port this plugin to use another library like Lamp, which seems like a good fit here. However, I wouldn't like to do all these changes without having some contact with the Terra team, however they also seem inactive.

[solonovamax]

It seems like this is an issue in the upstream cloud command framework from what I'm reading. We can't really fix that without patching the framework itself, and the framework seems to have become unmaintained which means that a PR there probably wouldn't result in it getting merged.

if that's the case, then I may consider forking cloud and making something derived from it

[TulipQiyi]

Hello, I am trying to enable this Terra on version 26.2. It throws a NoSuchMethodException during enabling, attempting to call CraftItemStack.asBukkitCopy(net.minecraft.world.item.ItemStack) via reflection, but this method signature does not exist in the server core. However, on version 26.1.2, it works fine. Is this version really compatible with 26.2? If so, how can I make it work?

It seems like this is an issue in the upstream cloud command framework from what I'm reading. We can't really fix that without patching the framework itself, and the framework seems to have become unmaintained which means that a PR there probably wouldn't result in it getting merged. I'd have to port this plugin to use another library like Lamp, which seems like a good fit here. However, I wouldn't like to do all these changes without having some contact with the Terra team, however they also seem inactive.

You just need to update this library to the latest version becuz they fixed this issue in 2.0.0-beta.16 <w<

[hui14]

你好，我正在尝试启用26.2版本的Terra。在启用过程中，它会抛出 NoSuchMethodException，尝试通过反射调用 CraftItemStack.asBukkitCopy（net.minecraft.world.item.ItemStack），但该方法签名在服务器核心中不存在。不过，在26.1.2版本上，它运行正常。这个版本真的兼容26.2吗？如果是这样，我该如何让它顺利进行？

据我所知，这似乎是上游云指令框架的问题。我们实际上无法修复，除非先修补框架本身，而且框架似乎已经无人维护，这意味着在那里进行PR可能不会导致合并。我得把这个插件移植到用另一个库，比如 Lamp，这在这里看起来很合适。不过，我不想在没有和Terra团队联系的情况下做所有这些改动，但他们似乎也处于不活跃状态。

你只需要把这个库更新到最新版本，因为这个问题在2.0.0-beta.16<w<修复了

Thank you, everyone! After I changed the version of bukkit.cloud in versions.kt to beta.16, it worked smoothly with 26.2.

[ArikSquad]

You just need to update this library to the latest version becuz they fixed this issue in 2.0.0-beta.16 <w<

Who maintains this version? The incendo/cloud repository doesn't seem to have such a version? I can bump it in this PR but I'm curious where it's coming from

[ArikSquad]

It seems like I've completely missed the cloud-minecraft repo. Thanks for the information

[ArikSquad]

This latest commit adds 26.3 support, it's done by a new module separation for nms versions through 26.1-26.3 which is not what Terra should target but this seems like the current best solution as these pull requests are not being merged, and me not wanting to create multiple different PRs that all build on top of each other as stacked PRs are not available from downstream.

I've also added support to the nbt data in entity spawning, as reimagEND used that.

[Nabi-dev01]

Hello, I’m currently running this on a Paper 26.3 server, but the part in question does not seem to work.
I wanted to ask if there is something I may have missed or if there is any additional configuration required.

Minecraft version: 26.3
Server software: Paper 26.3-140

Here is the error log:
https://pastebin.com/XUR0qjsh

[ArikSquad]

Hello, I’m currently running this on a Paper 26.3 server, but the part in question does not seem to work. I wanted to ask if there is something I may have missed or if there is any additional configuration required.

Sorry for the late response @Nabi-dev01, this should have been fixed in that latest commit. Biome stuff have apparently changed before 26.3 went into beta, which was last I tested this.