Avoid unnecessary regex compilation in hot paths - #951
Open
Smorki wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small optimizations to avoid unnecessary regex pattern compilation on frequently-called methods.
1.
BlockBreakLogger.log()— replacereplaceFirstwithreplaceThe lectern block data adjustment uses
String.replaceFirst("has_book=true", "has_book=false"), which internally compiles aPatternon every invocation. Since the search string is a literal (no regex metacharacters) and appears at most once in a BlockData string,String.replace(CharSequence, CharSequence)is functionally identical and avoids the pattern compilation.This method is called for every block break on the server, which is one of the highest-frequency events CoreProtect logs.
Change:
replaceFirst→replace(1 character).2.
Config.getInt()— cache the digit-strip patterngetInt()callsconfigured.replaceAll("[^0-9]", "")on every integer config read. Each call recompiles the regex. Extracting the pattern to aprivate static final Patternfield eliminates repeated compilation.Change: Added
NON_DIGIT_PATTERNstatic field and updated the call site to use it.