fix(signage): fill the frame with unpositioned floating items - #539
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
A floating template item with no saved position now defaults to 0, 0, so it fills the frame, matching the manager preview (#536).
MrYuion
force-pushed
the
fix/signage-player-floating-default
branch
from
October 2, 2026 05:50
bcfbe71 to
f1b303d
Compare
|
Deployment failed for project frontend-templates with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A floating template item with no saved position was placed at 50%/50% on the player, filling only the bottom-right quarter. In review of #536, the default was set to full screen instead: a floating panel without a position should fill the frame.
Changes
apps/signage/src/app/template-layout.ts:FLOATING_POSITIONis 0, so an unpositioned floating item fills the frame. A comment says it must stay in step with the manager preview.This is the player half of the review change on #536 (the manager preview and saved defaults). This commit was pushed to #528's branch after #528 had merged, so it needs its own PR.
Testing
nx test signagepasses (480).Notes
Merge order
Merge with #536 so the preview and the screens agree. Based on
develop.Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.
🤖 Generated with Claude Code