fix(signage-manager): fix media uploads, selection and animations - #534
Conversation
|
Deployment failed for project frontend-templates with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| /** Load the playlists again from the first page */ | ||
| public retry() { | ||
| this._playlist_service.reloadPlaylists(); |
There was a problem hiding this comment.
If a later playlist page fails, the new retry button calls reloadPlaylists. That clears pages that loaded successfully and starts again at page one. Retry the failed page instead so users keep their place and do not fetch those pages again.
There was a problem hiding this comment.
Agreed. The fix belongs in the playlist service, which #535 owns: there, reloadPlaylists() now calls PagedList.retry() first and reloads from page one only when the first page failed (commit c13152c, test "loads a later page again on retry and keeps the loaded pages"). The sidebar already calls reloadPlaylists(), so it keeps its loaded pages once #535 merges, with no change needed here.
|
LGTM |
- Reject unreadable files instead of waiting for ever, and prepare bulk uploads at most four at a time. - Open the edit modal when no thumbnail can be made. - Look up playlist usage with allSettled, four at a time. - Clear selection and the open folder on any group change. - Pick upload permissions in the edit modal. - Check 4K in either orientation and show the warning where it can be seen, naming files in bulk. - Map animation indexes from the backend to their names. - Error states in the sidebar and preview, plural delete text, and accessibility fixes.
… renders editMedia waited for the thumbnail render, up to 15 s for a video that could not produce a frame. It now opens the dialog at once with the pending thumbnail, and the upload uses that same render instead of rendering a second one.
96712eb to
ab7a90d
Compare
1 participant
On the media page:
cross_fade→2), so the saved animation never showed.Changes
getMediaMetadatarejects on a decode error or after 15 s, and revokes the URL. Unreadable files are skipped with an error. Bulk prepare runs at most 4 at once.allSettled, at most 4 at once.linkedSignals of the group.mediaAnimation()maps indexes to names. Names are still written.aria-labelledbyon selects, named close buttons,[(ngModel)], and dead code removed.Testing
nx test signage-manager(1001) andnx build signage-managerpass.Notes
mediaAnimationalso exists in fix(signage-manager): fix playlist approval, adding media and status #535; merge the two after both land.Independent of the other signage PRs from this review. Based on
develop.Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.
🤖 Generated with Claude Code