Skip to content

ci: run unit tests on Node 24 - #525

Merged
MrYuion merged 1 commit into
developfrom
ci/node-24-tests
Oct 2, 2026
Merged

MrYuion merged 1 commit into
developfrom
ci/node-24-tests

Conversation

@MrYuion

@MrYuion MrYuion commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

The unit test job ran on the runner image default (Node 22), while install_deps pins Node 24. Some web APIs differ between the two. For example, Response.blob() returns Node's own Blob before Node 24, so a test passed locally and failed in CI (#519).

Changes

  • Add actions/setup-node@v6 with Node 24 to the test job.
  • The build job is not changed, because it makes deploy builds.

Testing

  • Prettier check on the workflow. This PR's own CI run is the real test.

Independent of the other signage PRs from this review. Based on develop.


Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.

🤖 Generated with Claude Code

The test job used the runner image default, Node 22, while install_deps
pins Node 24. Web APIs such as Response.blob() differ between the two,
so tests could pass locally and fail in CI. The build job is unchanged.
@vercel

vercel Bot commented Oct 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
frontend-templates Ignored Ignored Oct 2, 2026 3:14am UTC

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Changes Node.js version in CI test pipeline.

The PR appears safe to merge; no actionable issue was established.

Summary

The unit-test job now uses Node.js 24, matching dependency setup and local runs. This aligns the Node-provided web APIs used by CI tests.

  • Adds Node.js 24 setup to the test job, matching install_deps.
  • Leaves the deploy-build job unchanged.

Reviews (1) · Last reviewed commit: "ci: run unit tests on Node 24"

@MrYuion
MrYuion merged commit 82d9b81 into develop Oct 2, 2026
3 checks passed
@MrYuion
MrYuion deleted the ci/node-24-tests branch October 2, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant