ci: run unit tests on Node 24 - #525
Merged
Merged
Conversation
The test job used the runner image default, Node 22, while install_deps pins Node 24. Web APIs such as Response.blob() differ between the two, so tests could pass locally and fail in CI. The build job is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit test job ran on the runner image default (Node 22), while
install_depspins Node 24. Some web APIs differ between the two. For example,Response.blob()returns Node's ownBlobbefore Node 24, so a test passed locally and failed in CI (#519).Changes
actions/setup-node@v6with Node 24 to thetestjob.buildjob is not changed, because it makes deploy builds.Testing
Independent of the other signage PRs from this review. Based on
develop.Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.
🤖 Generated with Claude Code