Conversation
|
Deployment failed for project frontend-templates with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
|
- Share one splash screen between the main, tabbed and video call views, and use the shared connecting screen in the video call view. - Share one system binding helper between the control and video call state services. - Share camera move, zoom and select commands between the camera controls, camera tooltip and call page. Highlight the last recalled preset in the camera tooltip. - Show the meeting list spinner while today's events load. - Remove unused code: the page view, the app's copy of the help tooltip, unused service state (volume, mute, blinds, screens, space), the dial view redirect, unused output list item handlers, the `simple` source select mode, and other unused fields. - Give the lighting tooltips and video call view unique selectors. - Drop tests for removed code and commented-out tests.
- Return to bootstrap when the system does not exist (404). Clear the stored system ID first, so bootstrap does not open it again. The removed space resource used to redirect, but looped back. - Select the splash by `[name="splash"]` in the e2e specs. The splash is now the `control-splash` element, not a `div`.
Another control can change the selected camera. The preset highlight belonged to the previous camera.
MrYuion
force-pushed
the
fix/control-ux-fixes
branch
from
October 1, 2026 15:23
ff896b5 to
6085fcb
Compare
MrYuion
force-pushed
the
refactor/control-cleanup
branch
from
October 1, 2026 15:23
829ea71 to
54e1b7b
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control app had three copies of the splash screen, two binding helpers, three copies of camera move/zoom/select logic, and a lot of unused code: a page view that always showed the same view, an unused copy of the help tooltip, unused service state, a dial view redirect that nothing used, and others. Copies had already drifted apart (for example, the two camera components used different move logic).
Changes
ui/splash.component.ts) for the main, tabbed and call views. The call view also uses the shared connecting screen.system-binding.ts) for the control and video call state services.ui/camera-commands.ts) for the camera controls, camera tooltip and call page. The tooltip now highlights the last recalled preset; that state existed but was never set.simplesource select mode, other unused fields.loadSpaceand clears the stored system ID first.[name="splash"], because it is no longer adiv.Visible changes
Testing
fix/control-ux-fixes(bootstrap host visibility, app routing timing, and Escape not closing tooltips, which the last PR in the stack fixes). None of them reach this change. They were not run ondevelopitself.Merge order
4 of 5. Based on
fix/control-ux-fixes. Next:fix/control-tester-findings.Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.
🤖 Generated with Claude Code