Conversation
… as given (PPT-2640) When a host change moves a meeting to the new host's calendar, the previous host was added back to the attendees before the meeting was re-sent, so they stayed in it even when the edit had removed them. The previous host is now only invited when the request still lists them. The frontend keeps them in the list by default, so an explicit removal is what changes. PPT-2640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a host change moves a meeting to the new host's calendar (#383),
updateadded the previous host back to the attendees before the meeting was re-sent. So the previous host stayed in the moved meeting even when the edit removed them, which is what QA hit on PPT-2640: Lynne removed from the attendees, request correct, response and calendar still have Lynne.The forced host attendee is now skipped when the meeting is moving to a new host, so the moved meeting is sent with the attendees as given. The frontend keeps the previous host in the list by default (the "previous host will remain an attendee" warning), so the default flow is unchanged and an explicit removal now sticks. Edits without a host change are unchanged.
Testing
spec/controllers/events_spec.cr: 57 examples, 0 failures. The same spec against master fails on the new assertion.PPT-2640