Skip to content

fix: suppress runtime metadata changefeed updates - #329

Merged
stakach merged 3 commits into
masterfrom
ai/146-runtime-changefeed-policies
Sep 16, 2026
Merged

stakach merged 3 commits into
masterfrom
ai/146-runtime-changefeed-policies

Conversation

@stakach

@stakach stakach commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Module error/timestamp updates, Driver and Zone metadata/status saves, and ControlSystem playlist/orientation saves, now persist without runtime changefeed notifications. Each model declares its ignored fields, including updated_at and generated search_vector where applicable.

Driver's after_save callback also avoids saving associated modules when their copied name and role already match. Driver.module_name and Module.name are not ignored: changed module names and roles still propagate and notify. The comparison also preserves repair of stale module metadata.

Review

  • Module excludes updated_at, has_runtime_error and error_timestamp; Module.name remains notification-producing.
  • Driver excludes name, description, update_available, update_info, compilation_output, updated_at and search_vector.
  • Zone excludes name, description, display_name, playlists, images, updated_at and search_vector.
  • ControlSystem adds playlists/orientation to its existing policy (updated_at was already ignored).
  • Other fields and mixed updates still notify; INSERT/DELETE and unconfigured models retain their behavior.
  • README documents coordinated replacement of installed ControlSystem policies. No new dependency or schema migration is required.

Verification

  • Red: 23 focused specs, 15 failures exposing unwanted direct and indirect events.
  • Green: 27 focused specs, zero failures/errors, including the added Module cases. Ordinary saves persist requested fields without CDC rows or PostgreSQL notifications; module-name/role propagation, stale-module repair, runtime/mixed changes and unconfigured Repository updates remain intact.
  • Formatting and Ameba pass (181 files); independent review approved.
  • Module extension red: 27 specs with exactly three failures for the newly ignored fields. Running-module save persistence, error timestamp clearing and Module.name/mixed notification regressions now pass.
  • Final stable/unstable CI, style and all PR checks passed at bbd5281: https://github.com/PlaceOS/models/actions/runs/35048020173.

Completes the additional-model scope in PlaceOS/local#146.

@github-actions github-actions Bot added the type: bug something isn't working label Sep 16, 2026
@stakach
stakach marked this pull request as ready for review September 16, 2026 02:20
@github-actions github-actions Bot added type: bug something isn't working and removed type: bug something isn't working labels Sep 16, 2026
@github-actions github-actions Bot added type: bug something isn't working and removed type: bug something isn't working labels Sep 16, 2026
@stakach
stakach merged commit ad917a3 into master Sep 16, 2026
8 checks passed
@stakach
stakach deleted the ai/146-runtime-changefeed-policies branch September 16, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant