Repository navigation
fix: suppress signage heartbeat changefeed events - #327
Merged
Merged
Conversation
stakach
marked this pull request as ready for review
September 16, 2026 01:25
21 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signage polling calls
ControlSystem#update_last_seen_time, which currently emits a configuration changefeed event and causes core to refresh logic modules. Declaresignage_last_seenandplaylist_item_idas ignored update columns so heartbeat-only writes persist without running EventBus's notification function.Require released pg-orm 2.4.0 and remove its unversioned override. Ordinary and mixed configuration updates, INSERT/DELETE and other model notifications remain intact. The existing single UPDATE is unchanged; no migration or core filter is needed.
Review
Verification