fix(place/bookings): PPT-2426 resolve asset names from Asset records - #636
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated desk and parking metadata contains an object instead of an asset list. AssetNameResolver now reads Asset records in those zones, so booking emails show the resource name and at-capacity notifications can find the zone's assets.
Legacy metadata arrays remain the capacity list. Individual names also fall back to Assets when an id is missing from metadata. The resolver accepts duplicate type names across categories, uses identifier then name then id, and caches the results with the existing timeout. Asset lookup failures log a warning. Locker handling is unchanged.
Local validation: both at-capacity and auto-release spec files pass, including 20 added cases. Against the unchanged master resolver, those cases produced 10 and 3 failures respectively. Driver formatting completed. No shared environment was changed.
CI subset jobs stop before running tests because the report cannot connect to the harness at localhost:8080. The style check also fails on six unchanged files already present on master.
Ticket: https://acaprojects.atlassian.net/browse/PPT-2426